Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases/v8.4.0 #781

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Releases/v8.4.0 #781

wants to merge 17 commits into from

Conversation

MeenaAlfons
Copy link
Contributor

@MeenaAlfons MeenaAlfons commented Nov 29, 2023

What does this PR do?

Deploying a release candidate for:

Checklist

  • All new functionality has tests.
  • All tests are passing.
  • New or changed API methods have been documented.
  • npm run format has been run

CHANGELOG

@MeenaAlfons MeenaAlfons added the release-minor Minor version bump label Nov 29, 2023
@kamalbennani
Copy link

Once released, this would of course unblock us, thank you again 🙇

@MeenaAlfons
Copy link
Contributor Author

@kamalbennani In addition to subscribing to channels and sending messages, the following features may get affected by switchCluster if it is not respecting the protocol. It would be a good idea to test them before using this version in production.

  • Private Channels
  • Presence Channels
  • User Authentication
  • Server-to-user messages
  • Watchlist Online Status

Happy to help 😊

@kamalbennani
Copy link

Do you know if it's failing due to my changes, or those are just flaky tests?

@MeenaAlfons
Copy link
Contributor Author

MeenaAlfons commented Nov 29, 2023

I've run the tests locally and found the issue. Now all tests are passing but the make command returns 1 in CI.

Given that all tests are passing, I'm gonna go ahead and release the "release candidate" :)

@MeenaAlfons MeenaAlfons added the deploy-release Deploy a release to Github, Npm, CDK, etc label Nov 29, 2023
@MeenaAlfons MeenaAlfons removed the deploy-release Deploy a release to Github, Npm, CDK, etc label Nov 29, 2023
@MeenaAlfons MeenaAlfons added the deploy-release Deploy a release to Github, Npm, CDK, etc label Nov 29, 2023
@MeenaAlfons
Copy link
Contributor Author

@kamalbennani It's released 🚀

@kamalbennani
Copy link

Hi @MeenaAlfons
Thanks for the release! I spotted a small issue where the original Pusher options were ignored once the switchCluster is invoked.
I'm pushing a small PR with tests to cover this use-case.
Sorry!

@kamalbennani
Copy link

PR: #783

@MeenaAlfons MeenaAlfons added deploy-release Deploy a release to Github, Npm, CDK, etc and removed deploy-release Deploy a release to Github, Npm, CDK, etc labels Dec 1, 2023
Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you'd like this issue to stay open please leave a comment indicating how this issue is affecting you. Thank you.

@stale stale bot added the wontfix label Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-release Deploy a release to Github, Npm, CDK, etc release-minor Minor version bump wontfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants