Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pool fee bridge fix #399

Merged
merged 3 commits into from
Jul 16, 2024
Merged

pool fee bridge fix #399

merged 3 commits into from
Jul 16, 2024

Conversation

zaryab2000
Copy link
Collaborator

No description provided.

@zaryab2000 zaryab2000 added bug Something isn't working priority-1 Indicates highest priority labels Jul 15, 2024
@zaryab2000 zaryab2000 requested a review from 0xNilesh July 15, 2024 10:14
@zaryab2000 zaryab2000 self-assigned this Jul 15, 2024
Copy link
Member

@0xNilesh 0xNilesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality wise LGTM

contracts/PushComm/PushCommV3.sol Outdated Show resolved Hide resolved
contracts/PushComm/PushCommV3.sol Outdated Show resolved Hide resolved
contracts/PushComm/PushCommV3.sol Outdated Show resolved Hide resolved
contracts/PushComm/PushCommV3.sol Outdated Show resolved Hide resolved
contracts/PushComm/PushCommV3.sol Outdated Show resolved Hide resolved
contracts/PushComm/PushCommV3.sol Outdated Show resolved Hide resolved
@zaryab2000 zaryab2000 merged commit 138e21f into 389-optimization-ccr Jul 16, 2024
@zaryab2000 zaryab2000 deleted the 396-feePool-state-fix branch July 16, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-1 Indicates highest priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

😈 [Feature Enhancement] - Include a feature to update PROTOCOL_POOL_FEES via crosschain
2 participants