Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the staging app loading issue #1924

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

mishramonalisha76
Copy link
Collaborator

Pull Request Template

Ticket Number

Description

  • Problem/Feature:

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior

  • After: What's changed now

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

@mishramonalisha76 mishramonalisha76 self-assigned this Oct 15, 2024
@mishramonalisha76 mishramonalisha76 linked an issue Oct 15, 2024 that may be closed by this pull request
Copy link

  • There is a typo in the infuraAPIKey variable initialization. It should be import.meta.env.VITE_APP_INFURA_PROJECT_ID instead of 'be75cf427a5c41f9badb591994019d22'.
  • In the links object, there is a typo in the URL. It should be 'https://discord.gg/pushprotocol' instead of 'https://discord.gg/pushporotocol'.
  • There are some missed commas after certain values within the CHAIN_DETAILS object.
  • In the CHAIN_DETAILS object:
    • For the Ethereum chain, the name property of the object should be 'ETH_TEST_SEPOLIA'.
    • For the BNB Testnet chain, the commAddress property should have a different value than the Polygon address.
    • For the Optimism Sepolia chain, the commAddress property should have a different value than the current value.
    • For the Polygon zkEVM Testnet chain, the commAddress property should have a different value than the current value.
    • For the Arbitrum Testnet chain, the commAddress property should have a different value than the current value.
    • For the Cyber Testnet chain, the chainid property should be chainId.
    • For the Base Sepolia chain, the chainid property should be chainId.
  • The API URL in infuraApiUrl is incomplete. It should be 'https://infura-ipfs.io/ipfs/' instead of 'https:/infura-ipfs.io/ipfs/'.

Apart from the identified issues mentioned above, the code looks fine.

All looks good.

Copy link

github-actions bot commented Oct 15, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-10-15 11:35 UTC

@rohitmalhotra1420 rohitmalhotra1420 merged commit 628b2dd into main Oct 15, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Staging app doesnot load
2 participants