Update Rewards Activities

[corlard3y]

Pull Request Template

#1920

Description

• Problem/Feature:
• Add Cyber to Activities List

Type of Change

• Bug fix
• New feature
• Code refactor
• Documentation update
• Other (please describe): Update Rewards Activities List

Checklist

• Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
  • Quick PR label added
• Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
  • DO NOT Merge PR label added

Frontend Guidelines

• Followed frontend guidelines as per the Guidelines Notion Doc

Build & Testing

• No errors in the build terminal
• Engineer has tested the changes on their local environment
• Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

• Before: Explain the previous behavior

• After: What's changed now

Additional Context

Review & Approvals

• Self-review completed
• Code review by at least one other engineer
• Documentation updates if applicable

Notes

[github-actions]

In the file src/modules/rewards/components/RewardsActivityIcon.tsx:

• There are several places where components are not being returned correctly, e.g., missing 'return' keyword before the component declaration.
• The 'if' conditions are missing the 'return' statements for the components that should be returned.
• There are placeholder comments without actual code inside, e.g., '// ...'.
• The 'if' conditions are inconsistent and should be switched to 'if-else if' or 'switch' statements for better clarity and efficiency.

In the file src/modules/rewards/components/RewardsActivityTitle.tsx:

• In the else block, the return statement does not return the JSX element correctly. Need to wrap it in a JSX element like <></>.

Overall, the code seems to have issues with returning JSX elements correctly based on certain conditions and missing return statements in conditional checks.

Please address these issues to ensure the code functions correctly.

[github-actions]

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-10-15 11:54 UTC

[rohitmalhotra1420]

@corlard3y I cannot see these activity and changes on deploy preview. Please add a video of the env it's present or get it added on dev so I can test it out on deploy preview.

[corlard3y]

@corlard3y I cannot see these activity and changes on deploy preview. Please add a video of the env it's present or get it added on dev so I can test it out on deploy preview.

I think this is only on Staging, already pinged Shoaib to deploy to dev as well.

[github-actions]

All looks good.