Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the name from Etheruem sepolia to mainnet on prod #1918

Merged

Conversation

abhishek-01k
Copy link
Collaborator

Pull Request Template

Ticket Number

#1917

Description

  • Problem/Feature:

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

Screenshot 2024-10-11 at 2 23 49 PM

Screenshot 2024-10-11 at 2 27 12 PM

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

Copy link

In the UtilityHelper.ts file:

  1. There is a missing closing curly brace } at the end of the dappTitle function.
  2. There is a missing closing parenthesis ) at the end of the dappTitle function after the template string.
  3. The export statements for MaskedChannels, envUtil, EnvHelper, networkName, chainNameBackendStandard, and aliasChainIdToChainName are missing closing curly braces }.
  4. In the EnvHelper object, the dappTitle function does not return any value in case neither isStaging nor isDev is true.
  5. There are syntax errors in the networkName object. Correct them by adding missing commas after each key-value pair.

In the DifferentChainPage.tsx file:

  1. The <Box> component's style properties are not properly defined. The justifyContent="center" attribute is misplaced.
  2. The closing </Box> tag is also misplaced and should be moved after the <Button> component.
  3. The <Button> component is missing the necessary styles attribute.

Make the necessary corrections to the identified issues.

Copy link

github-actions bot commented Oct 11, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-10-11 11:09 UTC

Copy link

In the UtilityHelper.ts file:

  1. There is a syntax error in the code. There is an extra closing brace '}' after the method definition for dappTitle().
  2. The MaskedChannels object is missing a closing brace '}' after the last key-value pair.
  3. The envUtil object is missing a closing brace '}' after the last key-value pair.
  4. The EnvHelper object is missing a closing brace '}' after the dappTitle() method.
  5. The networkName object is missing a closing brace '}' after the last key-value pair.
  6. The chainNameBackendStandard object is missing a closing brace '}' after the last key-value pair.
  7. There is a typo in the aliasChainIdToChainName object. 'ARBITRUMONE' should be replaced with 'ARBITRUM'.

In the DifferentChainPage.tsx file:

  1. The Box component is missing the opening '<Box' tag right before the 'justifyContent="center"'.
  2. The Button component is not properly wrapped inside the Box component.

Overall, these issues need to be fixed in the code.

Do you want me to provide specific corrections, or would you like to make the fixes yourself?

@rohitmalhotra1420 rohitmalhotra1420 merged commit 0ff4e61 into main Oct 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - In the Channel Creation page fix the name issue
2 participants