Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the extra chain id and chain change issue #1910

Conversation

abhishek-01k
Copy link
Collaborator

Pull Request Template

Ticket Number

#1895

Description

Removed the extra chain Id 84532 from the chain list and also fixed the issue while switching chains.

  • Problem/Feature:

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Blocknative's @web3-onboard/core package needed an upgrade from 2.22.2 -> 2.22.3
  • And 84532 chain Id is for Base sepolia added that too

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

Copy link

github-actions bot commented Oct 8, 2024

File: package.json

  1. In the scripts section, there is a command 'change' that seems to have a typo. It might be better to provide a more descriptive name or correct the typo.
  2. In the dependencies section, there are multiple dependencies that are using version ranges without specifying the range type. It's recommended to use a specific range type like '^' for minor or '~' for patch updates to ensure predictable behavior during updates.
  3. The 'lint' script is using the ESLint command but it's not specified as a development dependency in the package.json file. Note that it's common to have ESLint as a devDependency for linting purposes.
  4. The 'preview' script is using a command 'vite preview' which seems to be a custom command. It's important to ensure that this command works correctly and is documented for other developers.

All looks good.

File: src/common/Common.constants.ts

No specific issues found.

File: yarn.lock

  1. In the yarn.lock file, there are dependencies listed with version ranges but without specifying the range type (e.g., '@foo/bar: 1.0.0'). It's recommended to specify the range type for clarity and predictability during updates.

All looks good.

Copy link

github-actions bot commented Oct 8, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-10-09 08:54 UTC

@rohitmalhotra1420 rohitmalhotra1420 merged commit bab67d7 into main Oct 9, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - Remove extra Chain Id for BNB and test the functionality
2 participants