DApp-1798 enabled reward points banner

[rohitmalhotra1420]

Pull Request Template

Ticket Number

• Ticket Number

Description

• Problem/Feature:

Type of Change

• Bug fix
• New feature
• Code refactor
• Documentation update
• Other (please describe):

Checklist

• Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
  • Quick PR label added
• Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
  • DO NOT Merge PR label added

Frontend Guidelines

• Followed frontend guidelines as per the Guidelines Notion Doc

Build & Testing

• No errors in the build terminal
• Engineer has tested the changes on their local environment
• Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

• Before: Explain the previous behavior

• After: What's changed now
  Enabled the reward points notification

Additional Context

Review & Approvals

• Self-review completed
• Code review by at least one other engineer
• Documentation updates if applicable

Notes

[github-actions]

1. There is a typo in the function name setcurrentTime in the App component. It should be setCurrentTime to follow proper naming conventions.

2. In the App component, the console.enable function calls are not defined anywhere in the code. This might be a typo or missing implementation.

3. In the App component, the if (appConfig?.appEnv === 'prod') condition is duplicated. It appears twice with the same condition which is unnecessary.

4. The useEffect hook in the App component is missing dependencies array. You should provide appConfig.googleAnalyticsId as a dependency in the array.

5. The useSelector hooks in the App component have incorrect access to state. They should be updated to provide the state and destructure it properly.

6. There are commented out code blocks related to location and title state management in the App component. They may need to be reviewed and potentially cleaned up if no longer required.

7. Typo: Provess App should be Process App.

8. In the extendConsole function, the error handling message should be console.error('Extended console threw an error:', e); instead of console.error('Extended console() threw an error!');.

After addressing the above points, the code should be checked again for any remaining issues or potential improvements.

All looks good.

[github-actions]

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-10-01 13:29 UTC