Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DApp-1849 monotone icon support #1857

Merged
merged 1 commit into from
Sep 12, 2024
Merged

DApp-1849 monotone icon support #1857

merged 1 commit into from
Sep 12, 2024

Conversation

rohitmalhotra1420
Copy link
Collaborator

@rohitmalhotra1420 rohitmalhotra1420 commented Sep 12, 2024 •
edited
Loading

Pull Request Template

Ticket Number

Description

  • Problem/Feature:

Type of Change

Added the new monotone icons

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior

  • After: What's changed now

Screenshot 2024-09-12 at 1 41 59 PM

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

@rohitmalhotra1420 rohitmalhotra1420 added the Quick PR A PR that can be approved before finishing a coffee label Sep 12, 2024
@rohitmalhotra1420 rohitmalhotra1420 self-assigned this Sep 12, 2024
@github-actions GitHub Actions
Copy link

File: src/blocks/icons/components/ArbitrumMonotone.tsx

  1. The closing tag is missing for the first element.
  2. The fill-rule and clip-rule attributes should be inside the tag, not as separate attributes.
  3. The d attribute of the second element is incorrectly placed outside the tag.
  4. The closing tag is missing.

File: src/blocks/icons/components/BnbMonotone.tsx

  1. The d attribute of the additional elements are incorrectly placed outside the tag.
  2. The closing tag is missing.

File: src/blocks/icons/components/EtheriumMonotone.tsx

  1. The d attributes of the additional elements are incorrectly placed outside the tag.
  2. The closing tag is missing.

File: src/blocks/icons/components/OptimismMonotone.tsx

  1. The d attributes of the additional elements are incorrectly placed outside the tag.
  2. The closing tag is missing.

File: src/blocks/icons/components/PolygonMonotone.tsx

  • No code provided to review.

File: src/blocks/icons/components/PushMonotone.tsx

  • No code provided to review.

File: src/blocks/icons/index.ts

  • No code provided to review.

Overall, the code in the specified files has some structural issues such as missing closing tags, incorrect placement of attributes, and missing closing tags. Once these issues are fixed, the code should be good to go.

All looks good.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-09-12 11:26 UTC

@rohitmalhotra1420 rohitmalhotra1420 merged commit d8ff672 into main Sep 12, 2024
2 of 3 checks passed
@rohitmalhotra1420 rohitmalhotra1420 linked an issue Sep 12, 2024 that may be closed by this pull request
Add new monotone icons to the design system #1849
Closed
corlard3y pushed a commit that referenced this pull request Sep 20, 2024
@rohitmalhotra1420 @corlard3y
added the new monotone icons (#1857)
020a337
rohitmalhotra1420 added a commit that referenced this pull request Sep 30, 2024
@corlard3y @mishramonalisha76
@rohitmalhotra1420 @kalashshah @abhishek-01k
Rewards V2 (#1772)
652e7f8 
* added loading colour

* add icon

* add components

* update styles

* update mobile view

* update titles

* change button labels

* update multiplier

* update useDailyRewards hook

* update unlock profile modal changes

* update usedailyrewards hook

* fix isLoading onclick

* update locked status/ rewards ui

* update new users status

* add skeleton loader

* comment out stake push activities

* update skeleton loader

* update locked icon

* format text

* feat: add alert ds component (#1781)

* feat: add alert ds component

* chore: update alert ds acc to review

* chore: update component acc to review

* update alert for error messages

* update indexes

* Update Dashboard.tsx

* remove unusued

* fixed review comments

* Update Button.tsx

* update completed state

* fixed the spinner and button

* fixed the spinner and button

* Added spinner component (#1783)

* added spinner component

* added review changes

* added correct variants

* added the review comments

* added the review comments

* Add progress bar to ds (#1787)

* feat: add progress bar to ds

* chore: update progress bar according to review

* add loading state

* update locked status

* update isLocked

* update loading state

* remove disabled state from button

* update locked divider

* update error message

* fix icons and illustrations

* update naming and imports

* update reward activites hook

* update type

* add types

* resolve conments

* update box

* update text changes

* update text

* update points real time

* update mutiplier conditions in bonus

* update gap

* update padding referal section

* adjust daily section ui

* update stake array

* update stake api

* update rewards verification hook

* fix: yield farming layouts and resize buttons to take full width (#1793)

* Add support for erc1155 (#1794)

* chore: add support for erc1155

* chore: update uiweb version to include erc1155 support

* Replaced older tab implementation in trending channels with the new tab block component (#1800)

* added

* moved function to utils

* tab changes

* reverted rewards tab change

* Update Dashboard.utils.ts

* Opt-In Dropdown for dashboard (#1802)

* Opt-In Dropdown for dashboard

* Fixed the comments and issues

* Fixed the context issue

* DS-Dapp Notification Component  (#1801)

* add in-app semantics and block files

* update notification component

* add localstorage identifier

* update library

* add duration option

* resolve comments

* update comment fixes

* fix comments

* testing notification

* update notification component

---------

Co-authored-by: rohitmalhotra1420 <[email protected]>

* DApp-1804 tag component added in blocks (#1805)

* tag in progress

* implemented tag component

* Tag component implemented in blocks

* update hook and export component

* update code

* add componentdid mount flow

* update mount logic

* fix stake font size

* fix conflicts

* Fixed create channel ui , fixed message for unlock profile, removed governance from sidebar (#1817)

* fixed minor ui issues

* fixed minor ui issues

* fixed minor ui issues

* fixed select text color

* fixed select text color

* fixed select text color

* fixed chain issue

* fixed send notif delegate issue (#1822)

* fixed send notif delegate issue

* Fixed the send notification button on the navigation for delegatee list

* added fixes for alias

* added fixes for alias

* fixed review comment

---------

Co-authored-by: abhishek-01k <[email protected]>

* DApp-1799 blocks/table (#1824)

* table in progress

* in progress

* in progress

* table complete

* fixed header route +  reverted changes

* added alignment support

* set debug to false

* fix comments

* export type and fix issues

* update rewards notification

* fix loading state

* add activit days

* update locked status

* updates test whitelist file for nft claims

* fixed smart contract for alpha nft

* update reset time

* refactor code

* update fixes

* stake push

* update types

* update yarn.lock

* update icons

* update icons batch 2

* sort stake section

* add local storage key

* update hasEnded and has text

* fixed channel notifications (#1852)

* added the new monotone icons (#1857)

* added support for icons in tag components (#1853)

* update stat in yield farming data store (#1859)

* update refetch leaderboard

* fix double text issue - media query

* update icon

* hide notifs

* update font sizes

* fix invalid verification proof issue

* remove console

* update success flow

* fixes done

* removed the png file

* lock file fixed

* remove isActive Account in auth hook

---------

Co-authored-by: Monalisha Mishra <[email protected]>
Co-authored-by: rohitmalhotra1420 <[email protected]>
Co-authored-by: Kalash Shah <[email protected]>
Co-authored-by: Monalisha Mishra <[email protected]>
Co-authored-by: Abhishek <[email protected]>
Co-authored-by: abhishek-01k <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corlard3y corlard3y corlard3y approved these changes

@mishramonalisha76 mishramonalisha76 mishramonalisha76 approved these changes

@abhishek-01k abhishek-01k abhishek-01k approved these changes

Assignees

@rohitmalhotra1420 rohitmalhotra1420

Labels
Quick PR A PR that can be approved before finishing a coffee
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new monotone icons to the design system
4 participants
@rohitmalhotra1420 @corlard3y @mishramonalisha76 @abhishek-01k