Changed notification limit from 100000 to 100 for Inbox and spam page

[mishramonalisha76]

Pull Request Template

Ticket Number

• 1839

Description

• Problem/Feature:Changed notification limit from 100000 to 100 for Inbox and spam page

Type of Change

• Bug fix
• New feature
• Code refactor
• Documentation update
• Other (please describe):

Checklist

• Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
  • Quick PR label added
• Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
  • DO NOT Merge PR label added

Frontend Guidelines

• Followed frontend guidelines as per the Guidelines Notion Doc

Build & Testing

• No errors in the build terminal
• Engineer has tested the changes on their local environment
• Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

• Before: Explain the previous behavior

• After: What's changed now

Additional Context

Review & Approvals

• Self-review completed
• Code review by at least one other engineer
• Documentation updates if applicable

Notes

[github-actions]

In the file src/segments/Inbox.tsx:

1. In the fetchAllNotif function, there seems to be a misplaced object definition. The object properties should be wrapped in curly braces. It should be corrected as follows:

   const fetchAllNotif = async () => {
     setLoadFilter(true);
     try {
       const results = await userPushSDKInstance.notification.list('INBOX', {
         limit: 100,
         page: page,
         raw: true,
       });
       setNotif(parsedResponse);
       setLoadFilter(false);
     } catch (err) {
       console.error(err);
     }
   }

2. The handlePagination function is missing a closing brace and a closing parenthesis for the if condition. It should be fixed as follows:

   const handlePagination = async () => {
     if (filter) {
       setLimit(limit + 10);
     } else {
       loadNotifications();
     }
   }

In the file src/segments/Spam.tsx:

1. In the fetchAllNotif function, one closing parenthesis is missing after the raw: true property. It should be added as follows:

   const results = await userPushSDKInstance.notification.list('SPAM', {
     limit: 100,
     page: 1,
     raw: true,
   });

2. The commented-out dispatch function in the fetchAllNotif function should be considered for uncommenting based on the application's requirements.

3. In the fetchLatestNotifications function call within the useEffect hook, there seems to be a missing closing brace } after loadNotifications();.

Apart from these issues, the logic and code structures present in both files seem to be fine.

All looks good.

[github-actions]

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-09-04 11:51 UTC

[github-actions]

All looks good.

[mishramonalisha76]

Screen.Recording.2024-09-04.at.4.30.57.PM.mov

Its a bit faster in other wallets as compared to the wallet address mentioned in the video @rohitmalhotra1420