Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dapp 1767 spinner #1786

Merged
merged 7 commits into from
Jul 31, 2024
Merged

Dapp 1767 spinner #1786

merged 7 commits into from
Jul 31, 2024

Conversation

mishramonalisha76
Copy link
Collaborator

Pull Request Template

Ticket Number

Description

  • Problem/Feature:

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior

  • After: What's changed now

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

Copy link

  • In the Spinner.tsx file, there is an unnecessary import statement at the end for spinnerSemantics that is already defined within the file. You can remove it.
  • In the Spinner.tsx file, there are unused imports for getSpinnerSize and getSpinnerStrokeWidth. You should either remove these imports or utilize these functions in the code.

All looks good.

Copy link

github-actions bot commented Jul 31, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-07-31 13:30 UTC

@rohitmalhotra1420 rohitmalhotra1420 merged commit a530cbc into main Jul 31, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants