Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the text color in dashboard #1766

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

mishramonalisha76
Copy link
Collaborator

@mishramonalisha76 mishramonalisha76 commented Jul 26, 2024

Pull Request Template

Ticket Number

Description

  • Problem/Feature: Fixed the text color in dashboard.

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior
image image
  • After: What's changed now
image image

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

Copy link

  • In the EmptyChannelList component:
    • The margin property in <Box> should use the correct values. Change it to margin="spacing-xl none none none".
  • In the RewardsSection component:
    • In the flexDirection prop in the outer <Box>, the shorthand syntax is incorrect. It should be flexDirection="column".
  • Overall, the code structure and logic seem correct.

All looks good.

Copy link

github-actions bot commented Jul 26, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-07-26 07:00 UTC

@rohitmalhotra1420 rohitmalhotra1420 merged commit 9410e40 into main Jul 26, 2024
2 of 3 checks passed
corlard3y pushed a commit that referenced this pull request Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants