Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment out Base Chain changes #1762

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

corlard3y
Copy link
Collaborator

Pull Request Template

#1761

Description

Commenting out Base chain changes , till BE issue is resolved and we can come back to this and close it out

  • Problem/Feature:

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior

  • After: What's changed now
    Commented every encounter of Base chain till it is good to go live

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

@corlard3y corlard3y linked an issue Jul 22, 2024 that may be closed by this pull request
Copy link

In Faucets.tsx file:

  1. The object for 'Optimism' with id '11155420' is missing a closing curly brace '}'.
  2. The object for 'Polygon zkEVM' with id '2442' is missing a closing curly brace '}'.
  3. The object for 'Arbitrum' with id '421614' is missing a closing curly brace '}'.
  4. The object for 'Fuse' with id '123' is missing a closing curly brace '}'.
  5. The object for 'Cyber' with id '111557560' is missing a closing curly brace '}'.
  6. In the 'ToggleArrowImg' component, the closing tag for 'img' is missing.

In VerifyAlias.tsx file:

  1. The objects inside the 'Faucets' object are missing closing curly braces '}' for multiple ids.
  2. The 'checkAlias', 'checkAliasVerification' functions are not properly closed with curly braces '}'.
  3. The 'submitAlias' function is not properly handling all the cases and setting 'loading' state.
  4. 'dispatch(setProcessingState(0));' is placed outside any code block.

Regarding the config files:

  • config-dev.js and config-prod.js files seem to define configuration for different environments. Please carefully review the configurations based on the environment requirements.

After fixing the mentioned issues, please ensure to thoroughly test the functionality of the components and configuration files.

All looks good.

Copy link

github-actions bot commented Jul 22, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-07-23 06:06 UTC

@rohitmalhotra1420 rohitmalhotra1420 merged commit e413024 into main Jul 23, 2024
2 of 3 checks passed
corlard3y added a commit that referenced this pull request Jul 27, 2024
corlard3y added a commit that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

😈 - <TEMP: comment Base Changes
2 participants