Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Signing Push User from yield Farming V1 #1760

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

abhishek-01k
Copy link
Collaborator

Pull Request Template

#1750

Description

When you will click on Migrate to new pool or Unstake or Claim Rewards. Now Metamask will not ask to sign push profile

  • Problem/Feature:

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior

  • After: What's changed now

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

Copy link

  • There is a typo in 'inforWithoutBG.svg', it should be 'infoWithoutBG.svg'.
  • The 'Span' import from 'primaries/SharedStyling' seems incorrect, it should be 'SpanV2'.
  • There is a typo in 'ItemHV2', it should be 'ItemH2V'.
  • In the massClaimRewardsTokensAll function, there is a missing closing curly bracket and parentheses after setting txInProgressClaimRewards to false.
  • In the massClaimRewardsTokensAll function, the comment block is not closed properly.
  • There are missing closing parentheses and curly brackets in the massClaimRewardsTokensAll function during the catch block handling.
  • In the withdrawTokens function, there is a missing closing curly bracket after setting unstakeErrorMessage.
  • In the withdrawTokens function, there is a missing initialization of signer before using it.
  • In the depositLpToken function, the toastTitle and toastMessage properties are not set properly under the catch block.
  • In the depositLpToken function, there is a missing closing parentheses after setting toastMessage.
  • In the depositPushToken function, the toastMessage property is not set properly under the catch block.
  • In the depositPushToken function, the setActiveTab(0) should be set inside the success block.
  • There are several comments that are not correctly formatted or closed properly.
  • There are a few instances of incorrect spacing and indentation in the code.

All looks good.

Copy link

github-actions bot commented Jul 19, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-07-19 14:01 UTC

@rohitmalhotra1420 rohitmalhotra1420 merged commit da29ab4 into main Jul 19, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants