Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix verify issue after checking 'Remember Me' #1757

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

corlard3y
Copy link
Collaborator

@corlard3y corlard3y commented Jul 18, 2024

Pull Request Template

#1755

Description

Fix verify button not responding after clicking Remember me

https://www.loom.com/share/524ffd18b49c447ca9eb5eff51b59f60?sid=9f812ec2-a660-4f01-9c32-2f58cba05bc1

  • Problem/Feature:

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

@corlard3y corlard3y linked an issue Jul 18, 2024 that may be closed by this pull request
Copy link

  • There is a missing closing brace '}' after 'Remember?' condition block.
  • The 'key' variable is not defined in the 'storePGPKeyForUser' function, it should be defined as const key = getUniquePGPKey(account);.
  • The 'key' variable is not defined in the 'retrieveUserPGPKeyFromStorage' function, it should be defined as const key = getUniquePGPKey(account);.
  • There is a missing closing brace '}' after 'return value;' in 'retrieveUserPGPKeyFromStorage' function.
  • The 'key' variable is not defined in the 'getUniquePGPKey' function, it should be defined as const key = w2wHelper.walletToCAIP10({ account });.
  • The 'key' variable is not defined in the 'isPGPKey' function, it should be defined as const key = w2wHelper.walletToCAIP10({ account });.

Please update the code accordingly.

Copy link

github-actions bot commented Jul 18, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-07-18 15:47 UTC

@rohitmalhotra1420 rohitmalhotra1420 merged commit 4b8ab4d into main Jul 18, 2024
2 of 3 checks passed
corlard3y added a commit that referenced this pull request Jul 27, 2024
corlard3y added a commit that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - <Fix Verify issue after clicking 'Remember Me'>
2 participants