Dapp 1729 new channel dashboard UI #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishek-01k
added
the
DO NOT MERGE
|
|
rohitmalhotra1420
requested changes
Jul 25, 2024
src/modules/channelDashboard/components/ReactivateChannelFaucet.tsx
Outdated
Show resolved
Hide resolved
rohitmalhotra1420
requested changes
Jul 26, 2024
|
|
||
| export type ChannelDropdownTypes = { | ||
| title: string; | ||
| logo: FC<IconProps>; | ||
| onClick: () => void; | ||
| color: 'text-primary' | 'text-state-danger-bold' | 'text-state-success-bold'; | ||
| // color: 'text-primary' | 'text-state-danger-bold' | 'text-state-success-bold'; | ||
| color: '#17181B' | '#D43B3B' | '#00A47F'; |
There was a problem hiding this comment.
@abhishek-01k what's this? not the correct approach.
| title: 'Add Subgraph Details', | ||
| logo: Cube, | ||
| onClick: () => setActiveState('addSubgraph'), | ||
| color: '#17181B', //color is used like this because MenuItem has no color prop to pass and it is used as css={css}; |
There was a problem hiding this comment.
@abhishek-01k not the correct approach
Comment on lines
100
to
102
| color: ${Item.color}; | ||
| span { | ||
| color: ${Item.color}; |
There was a problem hiding this comment.
@abhishek-01k this needs to be fixed.
Comment on lines
101
to
103
| span { | ||
| color: ${Item.color}; | ||
| } |
There was a problem hiding this comment.
Incorrect approach
rohitmalhotra1420
approved these changes
Jul 27, 2024
rohitmalhotra1420
merged commit 88e0ef5
into
Feat-New-Channel-Creation-Flow
1 check failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
#1729
Description
New Dashboard UI for the channels created by a User
Type of Change
Checklist
Frontend Guidelines
Build & Testing
Screenshots/Video with Explanation
Before: Explain the previous behavior
After: What's changed now
Additional Context
Review & Approvals
Notes
Things left: