Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/Base Chain support #1741

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Feat/Base Chain support #1741

merged 2 commits into from
Jul 16, 2024

Conversation

corlard3y
Copy link
Collaborator

Pull Request Template

#1607

Description

CoinBase has invited us to deploy on Base chain, with the biggest incentive being the integration of Push Notifications in Coinbase Wallet.
So we are basically just adding Base chain support, it’s just going to be a new chain like the others we have, from polygon, Arbitrum, cyber and the rest that have been added beforehand. So this is a new one called Base Chain - IIntegration of Push will enable native visibility of notifications from base ecosystem in coinbase wallet. So you can create channels, send notifications on this chain.

  • Problem/Feature:
    Base Chain support

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior

  • After: What's changed now
    Added a channel on Base chain, and can send notifications from the chain as well
    Screenshot 2024-06-07 at 16 48 33

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

@corlard3y corlard3y linked an issue Jul 16, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jul 16, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-07-16 11:45 UTC

@rohitmalhotra1420 rohitmalhotra1420 merged commit 1b7165b into main Jul 16, 2024
1 of 3 checks passed
corlard3y added a commit that referenced this pull request Jul 16, 2024
* base chain changes

* add custom scroll bar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

😈 [Feature] - <Base Chain Support>
2 participants