Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add activityTypeId query param to points vault user list #1721

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Add activityTypeId query param to points vault user list #1721

merged 1 commit into from
Jul 11, 2024

Conversation

kalashshah
Copy link
Member

Pull Request Template

Ticket Number

Description

Add activityTypeId query param to points vault user list

Type of Change

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

@kalashshah kalashshah self-assigned this Jul 11, 2024
@github-actions GitHub Actions
Copy link

All looks good.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 11, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-07-11 12:00 UTC

@rohitmalhotra1420 rohitmalhotra1420 merged commit 5c45a83 into main Jul 11, 2024
2 of 3 checks passed
@rohitmalhotra1420 rohitmalhotra1420 linked an issue Jul 11, 2024 that may be closed by this pull request
🐛 [BUG] - Empty twitter handles in Admin list #1720
Closed
corlard3y pushed a commit that referenced this pull request Jul 16, 2024
@kalashshah @corlard3y
chore: add activityTypeId query param to points vault user list (#1721)
50a488d
corlard3y pushed a commit that referenced this pull request Jul 16, 2024
@kalashshah @corlard3y
chore: add activityTypeId query param to points vault user list (#1721)
cef99a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitmalhotra1420 rohitmalhotra1420 rohitmalhotra1420 approved these changes

Assignees

@kalashshah kalashshah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - Empty twitter handles in Admin list
2 participants
@kalashshah @rohitmalhotra1420