Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reject modal icon && Test Creation flow #1711

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Conversation

corlard3y
Copy link
Collaborator

@corlard3y corlard3y commented Jul 10, 2024

Pull Request Template

#1694

Description

  • Problem/Feature:

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior

  • After: What's changed now

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

Copy link

In the file src/components/chat/unlockProfile/UnlockProfile.tsx:

  1. There seems to be a misplaced block of code starting with if (wallet?.accounts?.length) { inside the useEffect hook. It should be moved outside the useEffect hook.
  2. In the JSX code, <ImageV2> component is not closed properly with />.
  3. The <SpanV2> component is missing the closing tag </SpanV2>.
  4. There is a missing closing tag for the <ItemVV2> component.
  5. The fontSize property is missing for the <SpanV2> component.

In the file src/components/chat/unlockProfile/UnlockProfileWrapper.tsx:

  1. There are curly braces missing around the else block in the UnlockProfileWrapper component.

In the file src/modules/rewards/Rewards.tsx:

  1. The UnlockProfileWrapper component is not properly imported.
  2. In the useEffect hook, the dependency array should include activeTab.
  3. There is a missing closing curly brace for the Rewards component.

In the file src/modules/rewards/components/ActivityVerificationButton.tsx:

  1. In the useVerifyDiscord hook, there is a missing closing curly brace for the handleDiscordVerification function.
  2. The activityData variable is missing the correct structure for the activityType === 'follow_push_on_twitter condition.
  3. The useAuthWithButton hook is not imported.
  4. In the useAuthWithButton hook, the if block is not closed properly with curly braces.
  5. The Button component is not imported.
  6. The Box component is missing the closing tag </Box> in the return statement.

In the file src/modules/rewards/components/RewardsActivitiesList.tsx:

  1. The commented out line // const isLoading = isLoadingUserDetails || isLoadingActivities; should be removed if not needed.
  2. The LoaderSpinner component is not imported.

All looks good.

Copy link

github-actions bot commented Jul 10, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://push-protocol.github.io/push-dapp/pr-preview/pr-1711/
on branch gh-pages at 2024-07-10 09:39 UTC

src/components/chat/unlockProfile/UnlockProfileWrapper.tsx Outdated Show resolved Hide resolved
src/components/chat/unlockProfile/UnlockProfileWrapper.tsx Outdated Show resolved Hide resolved
src/modules/rewards/Rewards.tsx Outdated Show resolved Hide resolved
src/modules/rewards/hooks/useRewardsAuth.tsx Outdated Show resolved Hide resolved
src/modules/rewards/hooks/useRewardsAuth.tsx Outdated Show resolved Hide resolved
src/modules/rewards/hooks/useWithAuthButton.tsx Outdated Show resolved Hide resolved
src/modules/rewards/hooks/useWithAuthButton.tsx Outdated Show resolved Hide resolved
Copy link

In the file UnlockProfile.tsx:

  1. There is a missing closing curly brace for the handleChatprofileUnlock function.
  2. The useEffect hook is missing its closing curly brace.
  3. Inside the ImageV2 component, there is a missing closing angle bracket at the end of the component.
  4. The SpanV2 component is missing its closing tag.
  5. In the SpanV2 component, the style properties are not enclosed in curly braces.
  6. The fontSize property in the SpanV2 component is missing an equal sign.
  7. There is a missing closing curly brace for the condition where isLoading is false.

In the file UnlockProfileWrapper.tsx:
8. The IntroContainerProps interface is missing a closing curly brace.
9. The return statement in the else part of the conditional check is missing in the UnlockProfileWrapper component.

In the file Rewards.tsx:
10. The useEffect hook is missing its closing curly brace.
11. The refetchActivity function in the ActivityVerificationButton component is missing a closing parenthesis in the useVerifyDiscord hook.
12. The action property in the handleTwitterVerification in the ActivityVerificationButton component is not enclosed in curly braces.
13. The isAuthenticated property in the useAuthWithButton hook is not enclosed in curly braces in the useMemo hook.
14. The return statement in the useMemo hook of the useAuthWithButton hook is missing a closing curly brace.
15. There is a missing closing curly brace at the end of the Rewards component.

In the file RewardsActivitiesList.tsx:
16. The isLoading variable is assigned to isLoadingUserDetails instead of isLoadingActivities.
17. There is a commented-out line that assigns isLoading to isLoadingUserDetails or isLoadingActivities. It should be removed.

Overall, there are various syntax errors, missing closing braces, and typos in the provided files that need to be corrected.

Copy link

In file src/components/chat/unlockProfile/UnlockProfile.tsx:

  1. Line 32: Missing closing bracket for the useEffect hook.
  2. Line 37: Typo in the comment "swiching" should be "switching".
  3. Line 57: Missing closing tag for the ImageV2 component.
  4. Line 77: Typo in the prop declaration, "fontSize" should be inside an object.
  5. Line 79: Missing closing tag for the SpanV2 component.

In file src/components/chat/unlockProfile/UnlockProfileWrapper.tsx:

  1. Line 16: The IntroContainerProps interface is missing a closing curly brace.
  2. Line 47: There should be a return statement for the else condition.

In file src/modules/rewards/Rewards.tsx:

  1. Line 54: There is a missing closing parentheses at the end of the file.

In file src/modules/rewards/components/ActivityVerificationButton.tsx:

  1. Line 27: Typo, the curly brace should be added after the useVerifyDiscord function call in the useVerifyTwitter block.
  2. Line 29: The action property needs to be assigned a value inside the if block for 'follow_push_on_twitter'.
  3. Line 32: The curly brace for the useMemo hook is not properly closed.
  4. Line 47: The if block is missing a closing curly brace in the useAuthWithButton hook.
  5. Line 47-49: There's a missing closing curly brace for the onSuccess argument.
  6. Line 49: The if block doesn't have a closing curly brace.
  7. Line 77: The Button component is not imported.
  8. Line 105: The missing closing parenthesis at the end of the file.

In file src/modules/rewards/components/RewardsActivitiesList.tsx:

  1. Line 30: Typo in isLoading definition, isLoadingActivities is not defined.
  2. Line 44: The array fill() method should have more values compared to the flatMap method in line 48.
  3. Line 58: The closing tag for the box component should be added at the end of the file.

In general, there are typos and syntax errors across the multiple files. You need to fix them as per the descriptions above.

@rohitmalhotra1420 rohitmalhotra1420 merged commit b4d001b into main Jul 10, 2024
2 checks passed
corlard3y added a commit that referenced this pull request Jul 16, 2024
* add reject modal icon

* fix review comments

* fix additional comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants