Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update horizontal padding on DS Buttons #1669

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

kalashshah
Copy link
Member

Pull Request Template

Ticket Number

Description

Problem/Feature:

  • Update horizontal padding on DS Buttons
  • Horizontal padding for buttons changed as follows:
    XS: 16px (s4)
    SM: 24px (s6)
    MD: 24 px (s6)
    LG: 32px (s8)

Type of Change

  • Other (please describe): CSS changes

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

Before
image

After
image

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

NA

@kalashshah kalashshah added DApp - DS Label for tickets related to the design system for DApp Quick PR A PR that can be approved before finishing a coffee labels Jun 25, 2024
Copy link

  1. In the code for buttonVariantStyles, all the CSS strings are correctly defined for different variants and states, and the syntax seems to be correct.
  2. The logic in the getButtonSizeStyles function for generating button size styles based on the size and iconOnly parameters also seems to be correct.

All looks good.

Copy link

github-actions bot commented Jun 25, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-06-25 07:41 UTC

Copy link
Collaborator

@rohitmalhotra1420 rohitmalhotra1420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@rohitmalhotra1420 rohitmalhotra1420 merged commit b1f0328 into main Jun 25, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DApp - DS Label for tickets related to the design system for DApp Quick PR A PR that can be approved before finishing a coffee
Projects
None yet
Development

Successfully merging this pull request may close these issues.

😈 [Feature Enhancement] - Button component padding adjustment- Global
2 participants