Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Mobile Input bar on Chat #1637

Merged
merged 5 commits into from
Jun 26, 2024
Merged

Conversation

corlard3y
Copy link
Collaborator

@corlard3y corlard3y commented Jun 14, 2024

Pull Request Template

#1557

Description

Input bar for chat is hidden on mobile

  • Problem/Feature:
    Input bar for chat is hidden on mobile

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior

Screenshot_20240612-202009

  • After: What's changed now

image

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

@corlard3y corlard3y added bug Something isn't working DO NOT MERGE If the PR/task is dependent on some other task add this label to the PR. labels Jun 14, 2024
@corlard3y corlard3y linked an issue Jun 14, 2024 that may be closed by this pull request
Copy link

In the MasterInterfacePage.tsx file:

  1. The allowfullscreen attribute should have a value of true or false like allowfullscreen={true} or allowfullscreen={false}.
  2. In the Container component styled definition, the comment block closure should be properly closed.
  3. In the Interface component styled definition, the closing curly brace is missing.
  4. In the PreviewOuter component styled definition, the closing curly brace is missing.
  5. In the PreviewBG component styled definition, there is a missing closing tag for the styled component.

After the necessary corrections are made, the code will be easier to understand and will work correctly.

All looks good.

Copy link

github-actions bot commented Jun 14, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-06-26 08:44 UTC

Copy link

In the MasterInterfacePage.tsx file:

  1. In the Container styled component, the min-height and max-height values are using 100dvh. It seems like there is a typo and should be changed to 100vh.

  2. The closing backticks () are missing for the Interface` styled component.

  3. The closing backticks () are missing for the PreviewOuter` styled div.

  4. The PreviewBG styled component has position: initial; which is incorrect. It should either be position: static; or position: relative; based on the intended behavior.

After addressing the above issues, the styling definitions look good.

So, in conclusion:

All looks good.

@corlard3y corlard3y changed the title update master interface styling Fix: Mobile Input bar on Chat Jun 14, 2024
Copy link

There are some issues found in the provided code:

In src/App.tsx:

  1. Typo in variable name "SidebarCollapsable". It should be "sidebarCollapsible".
  2. Missing closing curly brace '}' for the useEffect hook for setting background color based on darkMode.
  3. Misplaced closing curly brace for the handleJoyrideCallback function.
  4. Unclosed function brackets for the setViewportHeight function.
  5. Missing return statement in the useEffect hook for removing event listener.

In src/modules/chat/ChatModule.tsx:

  1. Missing closing curly brace '}' for the Container styled component.
  2. Missing closing curly brace '}' for the ChatSidebarContainer styled component.
  3. Improper formatting in the height calculation of Container styled component.
  4. Missing closing curly brace '}' for the border property in the Container styled component.
  5. Missing closing curly brace '}' for the ChatContainer styled component.

In src/structure/MasterInterfacePage.tsx:

  1. Misplaced closing curly brace within the PreviewBG component.

After fixing the mentioned issues, the code should be reviewed again thoroughly.

Overall, the structure and styling of the components seem well-defined. Ensure the functionality is correctly implemented as intended.

All looks good.

Copy link

In the file src/App.tsx:

  1. There is a missing closing backtick symbol in the ParentContainer styled component definition.
  2. One of the margin declarations is duplicated in the ParentContainer styled component.
  3. The comment syntax used in the CSS is not valid. Use /* */ instead of // to comment out CSS.
  4. In the LeftBarContainer styled component, the position: absolute; property is commented out.
  5. In the ContentContainer styled component, there is a redundant margin declaration.

The code in src/App.tsx file needs some corrections for the CSS styled components.

In the file src/modules/chat/ChatModule.tsx:

  1. The closing parentheses and curly braces are missing at the end of the Container styled component.
  2. The border property is missing a value in the Container styled component.
  3. There are missing closing parentheses and curly braces in the media query declarations for laptop and mobile devices.
  4. The closing parentheses and curly braces are missing at the end of the ChatSidebarContainer styled component.
  5. The closing parentheses and curly braces are missing at the end of the ChatContainer styled component.

In the file src/structure/MasterInterfacePage.tsx:

  1. The closing parentheses and curly braces are missing at the end of the Container styled component.
  2. The Interface styled component has commented out properties that are not closed properly.
  3. The PreviewOuter styled component is missing closing parentheses and curly braces.
  4. The PreviewBG styled component is missing closing parentheses and curly braces.

After making these corrections, please recheck the code.

@corlard3y corlard3y removed the DO NOT MERGE If the PR/task is dependent on some other task add this label to the PR. label Jun 21, 2024
@corlard3y corlard3y requested review from HarshRajat and rohitmalhotra1420 and removed request for HarshRajat June 21, 2024 01:10
Copy link
Member

@kalashshah kalashshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rohitmalhotra1420 rohitmalhotra1420 merged commit 95a096e into main Jun 26, 2024
2 checks passed
corlard3y added a commit that referenced this pull request Jul 1, 2024
* update master interface styling

* add dynamic height

* pause changes

* use dvh

* remove function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - <MOBILE: Input bar for chat is hidden on mobile>
4 participants