-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/Base Chain support #1608
Feat/Base Chain support #1608
Conversation
In the file
In the file
In the file
In the file
Kindly make the necessary corrections based on the observations mentioned above. |
|
In the file {
id: '97',
value: 'BNB',
title: 'BNB Faucet',
function: () => {},
link: 'https://testnet.bnbchain.org/faucet-smart',
},
{
id: '11155420',
value: 'Optimism',
title: 'Optimism Sepolia Faucet',
link: 'https://faucet.quicknode.com/optimism/sepolia',
},
{
id: '2442',
value: 'Polygon zkEVM',
title: 'Polygon zkEVM Bridge',
link: 'https://faucet.polygon.technology/',
},
{
id: '421614',
value: 'Arbitrum',
title: 'Arbitrum Testnet Faucet',
link: 'https://faucet.quicknode.com/arbitrum/sepolia',
},
{
id: '123',
value: 'Fuse',
title: 'Fuse Sparknet Faucet',
link: 'https://chaindrop.org/?chainid=123&token=0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee',
},
{
id: '111557560',
value: 'Cyber',
title: 'Cyber Faucet',
link: 'https://cyber-testnet.testnets.rollbridge.app/',
},
{
id: '84532',
value: 'Base Sepolia',
title: 'Base Sepolia Faucet',
link: 'https://www.alchemy.com/faucets/base-sepolia',
} In the file 80002: {
label: 'Amoy MATIC',
url: 'https://faucet.polygon.technology/',
},
97: {
label: 'Testnet BNB',
url: 'https://testnet.bnbchain.org/faucet-smart',
},
11155420: {
label: 'Sepolia OpETH',
url: 'https://faucet.quicknode.com/optimism/sepolia',
},
2442: {
label: 'Polygon zkEVM ETH',
},
421614: {
label: 'Sepolia ArbETH',
url: 'https://faucet.quicknode.com/arbitrum/sepolia',
},
123: {
label: 'Fuse SPARK',
url: 'https://chaindrop.org/?chainid=123&token=0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee',
},
111557560: {
label: 'Cyber ETH',
url: 'https://cyber-testnet.testnets.rollbridge.app/',
},
84532: {
label: 'Base Sepolia',
url: 'https://www.alchemy.com/faucets/base-sepolia',
} In the same file aliasRPC: {
80002: 'https://polygon-amoy.infura.io/v3/5524d420b29f4f7a8d8d2f582a0d43f7',
97: 'https://data-seed-prebsc-1-s1.binance.org:8545',
11155420: 'https://optimism-sepolia.infura.io/v3/5524d420b29f4f7a8d8d2f582a0d43f7',
2442: 'https://rpc.cardona.zkevm-rpc.com',
421614: 'https://arbitrum-sepolia.infura.io/v3/5524d420b29f4f7a8d8d2f582a0d43f7',
}, In the file } // Add this closing brace Additionally, there is an if (caipArr.length == 3 && caipArr[0] == 'eip155') {
return caipArr[2];
}
throw new Error('Invalid CAIP Format'); After these corrections are made, the code should be free of syntax errors. |
I have reviewed the provided code and found some issues and potential improvements: File: package.json
File: public/svg/Base.svg
File: src/components/ChangeNetwork.tsx
File: src/components/Faucets.tsx
File: src/components/InitState.tsx
File: src/components/VerifyAlias.tsx
File: src/helpers/CaipHelper.ts
File: src/connectors/chains.ts
File: Other filesFiles like General
Please address the above-mentioned issues in the respective files. Let me know if you need any further assistance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -9,6 +9,7 @@ type Props = { | |||
}; | |||
|
|||
export const getAliasDetails = async ({ account, chainId }: Props) => { | |||
console.log(account, aliasChainIdToChainName[chainId], appConfig.appEnv); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's remove this.
* resolve qa comments * add verifying state * update button size * fix review comments
… components (#1716) * update changes * add props type * update version and remove on dash * added support for new css variables * deleted curropted file * added gap type --------- Co-authored-by: corlard3y <[email protected]>
…nt (#1700) * chore: support auto icon sizing in blocks button component * chore: update css selector for button icon styles
* add context * add create * add line * remove unused * fixed the error message logic for unlock profile * fixed the loading state of verify button for activities --------- Co-authored-by: rohitmalhotra1420 <[email protected]>
* refactored the input code * refactored the input code * Update PointsVaultLogin.tsx
* fix leaderboard issues * add scroll bar visible
Pull Request Template
#1607
Description
CoinBase has invited us to deploy on Base chain, with the biggest incentive being the integration of Push Notifications in Coinbase Wallet.
So we are basically just adding Base chain support, it’s just going to be a new chain like the others we have, from polygon, Arbitrum, cyber and the rest that have been added beforehand. So this is a new one called Base Chain - IIntegration of Push will enable native visibility of notifications from base ecosystem in coinbase wallet. So you can create channels, send notifications on this chain.
Base Chain support
Type of Change
Checklist
Frontend Guidelines
Build & Testing
Screenshots/Video with Explanation
Before: Explain the previous behavior
After: What's changed now
Added a channel on Base chain, and can send notifications from the chain as well
Additional Context
Review & Approvals
Notes