Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor UI fixes in Inbox and Yield Farming #1533

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

abhishek-01k
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
push-dapp ❌ Failed (Inspect) May 16, 2024 1:35am

@abhishek-01k abhishek-01k linked an issue May 16, 2024 that may be closed by this pull request
2 tasks
Copy link

In the StakingModalComponent.tsx file:

  1. There is a missing closing curly brace } after the setDepositApprove(false); statement inside the handleInput function.
  2. In the setDepositAmountMax function, there is a missing closing curly brace } after the statement.
  3. The border property in the TokenInput component is missing a closing quotation mark.
  4. The FilledButton component has a typo in the depositApproved variable name. It should be depositApprove.
  5. The disabled attribute in the FilledButton component should be set to !depositApprove instead of !depositApproved.

In the Inbox.tsx file:

  1. The NotifsOuter component has a missing closing curly brace } after the margin: 25px 0px; statement.
  2. The Notifs component has a missing closing curly brace } after the flex: 1; statement.
  3. The ToasterMsg component is missing styling declarations.
  4. The SnapSection component has duplicate gap property declarations, and the box-sizing property should not have a separate line.
  5. The InstallText component has an unnecessary line break, remove display: block;.
  6. The CloseButton component's hover effect text-underline-position is misspelled, it should be text-decoration.
  7. The InstallPushSnap component is missing a closing curly brace }.
  8. The ScrollItem component is missing styling declarations.

Please correct the identified issues in the respective files.

Copy link
Collaborator

@rohitmalhotra1420 rohitmalhotra1420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rohitmalhotra1420 rohitmalhotra1420 merged commit 7d93a02 into main May 21, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - Minor UI issues on the dapp
2 participants