Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added temporary commit #1532

Closed
wants to merge 2 commits into from
Closed

Conversation

0xNilesh
Copy link
Member

No description provided.

Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
push-dapp ❌ Failed (Inspect) May 15, 2024 7:08pm

Copy link

  1. In the isEmpty function, you should use === instead of == for strict equality comparison. Update if (field.trim().length == 0) to if (field.trim().length === 0).

  2. In the isAllFilledAndValid function parameters, the coreChainId should be of a specific type, for example, number or string. Make sure it matches the type used in the comparisons.

Other than these points, the logic and structure of the code seem correct.

All looks good.

Copy link

github-actions bot commented May 15, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-05-16 08:14 UTC

Copy link

In file src/components/ChannelDetails.jsx:

  1. Line 43: The closing tag for <SpanV2> is incomplete. It should be </SpanV2>.
  2. Line 77: The closing tag for <AdaptiveMobileItemVV2> is incomplete. It should be </AdaptiveMobileItemVV2>.
  3. Line 90: The opening tag for <ItemVV2> is missing the > symbol at the end.
  4. Line 96: The closing tag for <ItemVV2> is missing. Add </ItemVV2> before line 97.
  5. Line 105: The closing tag for <ItemVV2> is missing. Add </ItemVV2> before line 106.
  6. Line 113: The closing tag for <SectionDes> is missing. Add </SectionDes> before line 114.
  7. Line 125: There is a syntax error in the JSX props. Fix it to <SectionDate></SectionDate>.

In file src/helpers/InputValidation.ts:

  1. Line 30: After description: 'Please, enter the channel description',, add a closing curly brace }.
  2. Line 32: The url property assignment is not correctly formatted. You should fix it to url: 'Please, enter the channel url'.
  3. There are many ellipses (...) and redundant comments which should be removed for cleaner code.

Please correct the identified issues and run the code again.

All looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant