Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for cyber-connect chain #1528

Merged
merged 3 commits into from
May 16, 2024
Merged

Conversation

0xNilesh
Copy link
Member

No description provided.

Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
push-dapp ❌ Failed (Inspect) May 16, 2024 0:29am

Copy link

In the src/components/Faucets.jsx file:

  1. The Faucets object is missing closing curly braces for objects with keys 97, 2442, and 11155420.
  2. In the checkAlias function, the submitAlias function is not being called within the if block properly.
  3. The checkAliasVerification function is missing a closing curly brace after the if condition.
  4. In the submitAlias function, there is an extra setLoading('Loading...'); line that seems unnecessary.
  5. There are some syntax issues with object keys having the same id like id: "3" in the Faucets object. Each object should have a unique id key.
  6. The Faucet component is missing from the code snippet provided, so it's hard to check the logic related to the component.

Please ensure that these issues are resolved for proper functionality.

File: src/components/Faucets.jsx

const Faucets = {
  80002: {
    label: "Amoy MATIC",
    url: "https://faucet.polygon.technology/"
  },
  97: {
    label: "Testnet BNB",
    url: "https://testnet.bnbchain.org/faucet-smart"
  }, // Added missing closing curly brace
  11155420: {
    label: "Sepolia OpETH",
    url: "https://faucet.quicknode.com/optimism/sepolia"
  }, // Added missing closing curly brace
  2442: {
    label: "Polygon zkEVM ETH",
  }, // Added missing closing curly brace
  421614: {
    label: "Sepolia ArbETH",
    url: "https://faucet.quicknode.com/arbitrum/sepolia"
  },
  123: {
    label: "Fuse SPARK",
    url: "https://chaindrop.org/?chainid=123&token=0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee"
  },
  111557560: {
    label: "Cyber ETH",
    url: "https://cyber-testnet.testnets.rollbridge.app/"
  }
}

In the other files provided, I couldn't find any specific issues based on the provided snippets.

If the missing parts of the code are necessary to review, please provide more context or the missing code snippets.

All looks good.

Copy link
Collaborator

@rohitmalhotra1420 rohitmalhotra1420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xNilesh some minor improvements. Rest looks good.

src/components/VerifyAlias.jsx Show resolved Hide resolved
@0xNilesh 0xNilesh merged commit 151ce74 into main May 16, 2024
1 of 3 checks passed
@0xNilesh 0xNilesh deleted the feat/support-cyber-connect branch May 16, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 [New Feature] - Add Support for CyberConnect chain
2 participants