Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vercel pull request preview #1519

Closed
wants to merge 14 commits into from
Closed

Conversation

rohitmalhotra1420
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented May 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
push-dapp ❌ Failed (Inspect) May 13, 2024 5:34pm

Copy link

There are several issues in the provided file:

  1. In the .gitignore file, the section for ignoring node_modules is repeated twice, once at the top level and then within the /packages/react-app/node_modules/ section. This duplication is unnecessary.
  2. In the /packages/react-app/node_modules/, a typo in the folder name is present. It says /packages/react-app/node_modules/ instead of /packages/subgraph/node_modules/.
  3. The inclusion of dump.rdb at multiple places seems redundant. Consider removing the duplicate entries.
  4. There is a random line compressionLevel: mixed that doesn't belong in a .gitignore file. It seems like it's a configuration setting mistakenly added here.
  5. The section at the end related to package-lock.json, .pnp.*, and enableGlobalCache appears to be misplaced in the .gitignore file.

After addressing these issues, the final .gitignore file should look as follows:

# See https://help.github.com/articles/ignoring-files/ for more about ignoring files.

# dependencies
/node_modules
/.pnp
.pnp.js

# testing
coverage

# production
build
dump.rdb

# misc
.DS_Store
.env

# debug
npm-debug.log*
yarn-debug.log*
yarn-error.log*

/packages/react-app/node_modules/
/packages/subgraph/build/
/packages/subgraph/node_modules/
/packages/subgraph/src/types/

# Created by .ignore support plugin (hsz.mobi)
.vscode/*
!.vscode/settings.json
!.vscode/tasks.json
!.vscode/launch.json
!.vscode/extensions.json

As for the line compressionLevel: mixed and the latter part of the file related to configuration settings, it seems like it should be part of a different file, likely a configuration file rather than a .gitignore file.

After addressing these issues, the content may be updated or moved to the appropriate file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants