Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/migrate zkevm cardona #1497

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Feat/migrate zkevm cardona #1497

merged 2 commits into from
Apr 24, 2024

Conversation

0xNilesh
Copy link
Member

No description provided.

Copy link

vercel bot commented Apr 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
push-dapp ❌ Failed (Inspect) Apr 23, 2024 11:54am

Copy link

In the package.json file, there is a missing comma after each object inside the dropdownValues array in the src/components/Faucets.jsx file. Each object should be separated by a comma. Here's the corrected part of the code:

const dropdownValues = [
  {
    id: "11155111",
    value: "Sepolia",
    title: "Sepolia Faucet",
    function: () => {},
    link: "https://sepoliafaucet.com/",
  },
  {
    id: "80002",
    value: "Polygon",
    title: "Amoy Faucet",
    link: "https://faucet.polygon.technology/",
  },
  {
    id: "97",
    value: "BNB",
    title: "BNB Faucet",
    link: "https://testnet.bnbchain.org/faucet-smart",
  },
  {
    id: "11155420",
    value: "Optimism",
    title: "Optimism Sepolia Faucet",
    link: "https://faucet.quicknode.com/optimism/sepolia",
  },
  {
    id: "2442",
    value: "Polygon zkEVM",
    title: "Polygon zkEVM Bridge",
    link: "https://faucet.polygon.technology/",
  },
  {
    id: "421614",
    value: "Arbitrum",
    title: "Arbitrum Testnet Faucet",
    link: "https://faucet.quicknode.com/arbitrum/sepolia",
  },
  {
    id: "123",
    value: "Fuse",
    title: "Fuse Sparknet Faucet",
    link: "https://chaindrop.org/?chainid=123&token=0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee",
  },
];

In the src/config/config-dev.js file, there are missing commas in the Faucets object. Each key-value pair should be separated by a comma. Here's the corrected part of the code:

const Faucets = {
  80002: {
    label: "Amoy MATIC",
    url: "https://faucet.polygon.technology/"
  },
  97: {
    label: "Testnet BNB",
    url: "https://testnet.bnbchain.org/faucet-smart"
  },
  11155420: {
    label: "Sepolia OpETH",
    url: "https://faucet.quicknode.com/optimism/sepolia"
  },
  2442: {
    label: "Polygon zkEVM ETH",
  },
  421614: {
    label: "Sepolia ArbETH",
    url: "https://faucet.quicknode.com/arbitrum/sepolia"
  },
  123: {
    label: "Fuse SPARK",
    url: "https://chaindrop.org/?chainid=123&token=0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee"
  },
};

Other than that, all looks good.

@0xNilesh 0xNilesh merged commit 21dea37 into main Apr 24, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

😈 [Feature Enhancement] - Migrate polygon zkevm testnet to polygon zkevm cardona testnet
1 participant