Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel profile scrollfix #1467

Merged
merged 2 commits into from
Mar 23, 2024
Merged

Channel profile scrollfix #1467

merged 2 commits into from
Mar 23, 2024

Conversation

HarshRajat
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Mar 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
push-dapp ❌ Failed (Inspect) Mar 23, 2024 2:40am

@HarshRajat HarshRajat merged commit ec9817d into main Mar 23, 2024
2 of 4 checks passed
Copy link

In the .env.sample file:

  1. Typo in 'DEPLOY_ENN', should be 'DEPLOY_ENV'.
  2. PUBLIC_URL missing quotes in the value.
  3. Typo in 'REACT_APP_IPFS_INFURA_API_SECRET', it should be 'REACT_APP_IPFS_INFURA_API_KEY'.
  4. TSC_COMPILE_ON_ERROR should be uncommented.
  5. GENERATE_SOURCEMAP should be set to true or removed, as false might impact debugging.
  6. 'EXTEND_ESLINT' is commented out.

In the public/index.html file:

  • The comments section is informative but should be enclosed within comment tags

File: src/segments/ChannelProfile.tsx

  • The file is empty. If this is intentional, there's nothing to review.

All other files seem to have the correct structure and content.

Final Review Comment:
There are some typos and incorrect configurations in the .env.sample file and public/index.html file. Please address those mentioned issues.

All looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant