Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ios native browser issue #1462

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Fix/ios native browser issue #1462

merged 2 commits into from
Mar 19, 2024

Conversation

0xNilesh
Copy link
Member

No description provided.

Copy link

vercel bot commented Mar 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
push-dapp 🔄 Building (Inspect) Visit Preview Mar 19, 2024 11:32am

Copy link

In the file Themization.js:

  1. In the 'themeLight' object, there are missing closing curly braces '}' for objects like 'login', 'header', 'nav', 'chat', 'btn'.
  2. The property 'chat' is misspelled as 'chatboxBg' should be corrected to 'chatboxBg'.
  3. The property 'backgroundColor' is misspelled as 'backgroundBG' should be corrected to 'backgroundColor'.
  4. In the 'themeDark' object, there are multiple duplicate 'bg' properties, they should be removed.
All looks good.

In the AlphaAccessNftHelper.ts file:

  1. In the 'getProof' method, the 'userAddress' variable should be compared as lowercase with the entries in the 'whitelistAddressesList' which are also in lowercase.
  2. In the 'verify' method, the 'hashedAddress' variable is not defined, it should be defined as 'keccak256(userWalletAddress)'.
All looks good.

In the Navigation.tsx file:
This file is empty and does not contain any code to review.

All looks good.

@0xNilesh 0xNilesh merged commit b87bfb7 into main Mar 19, 2024
2 of 4 checks passed
@0xNilesh 0xNilesh deleted the fix/ios-native-browser-issue branch March 19, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant