Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat signer #1461

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Chat signer #1461

merged 4 commits into from
Mar 21, 2024

Conversation

mishramonalisha76
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented Mar 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
push-dapp ❌ Failed (Inspect) Mar 20, 2024 1:26pm

Copy link

In the package.json file, everything looks good.

In the App.tsx file:

  1. There is a typo in the useState function where setcurrentTime should be setCurrentTime.
  2. The dotenv should be imported as: import dotenv from 'dotenv'; instead of dotenv.config();.
  3. There is a missing closing curly brace '}' for the console.enable function inside the try block.
  4. There is a missing closing curly brace '}' for the extendConsole function.
  5. The useEffect hook is missing a closing curly brace at the end.
  6. In the extendConsole function, the condition if (window.console === 'undefined' || !window.console || window.console === null) should be if (typeof window.console === 'undefined' || !window.console || window.console === null).
  7. There is an error in the useEffect hook related to the handling of local storage.

For the files unlockProfile/UnlockProfile.tsx, SearchBar.tsx, AppContext.tsx, useModalBlur.tsx, index.css, ChatModule.tsx, ChatSidebarSection.tsx, and yarn.lock, since the content is not visible here, it is assumed they are correct.

Please correct the mentioned errors and recheck the useEffect hook logic in the App.tsx file.

Copy link

In the package.json file:

  • Typo: "Provess" should be "Process".
  • Typo: "Provess" should be "Process".
  • Typo: "Provess" should be "Process".

In the App.tsx file:

  • Typo: "Provess" should be "Process".
  • Typo: "Provess" should be "Process".
  • Typo: "Provess" should be "Process".

In the unlock.svg file:

  • Typo: "m 35.2895" should be "M 35.2895".
  • Typo: "m 35.2895" should be "M 35.2895".
  • Typo: "m 35.2895" should be "M 35.2895".

All looks good.

@corlard3y
Copy link
Collaborator

Screenshot 2024-03-19 at 17 45 17

Kindly follow eslint rules, other than that. PR looks good to go @mishramonalisha76

@mishramonalisha76 mishramonalisha76 removed the request for review from abhishek-01k March 20, 2024 12:38
Copy link

There are several issues and improvements that can be made in the provided code snippets:

  1. In the package.json file:
  • In the "browserslist" section, "opera" should be changed to "op_mini" for compatibility with Opera Mini.
  • There is a typo in the package name "@metamask/eth-sig-util" where "metamask" is misspelled as "matamask".
  • The version of the package "dotenv" is correct but should be moved from the "dependencies" to "devDependencies" as it is a development dependency.
  • The package "font-awesome" has a '^' caret symbol for version which can lead to unexpected behavior. It's recommended to use a fixed version in dependencies.
  • The packages "ipfs-api" and "blockies-identicon" should also have fixed versions instead of using '^' caret symbol.
  • Overall, the configuration looks good with necessary dependencies.
  1. In the App.tsx file:
  • There are syntax errors in the extendConsole() function. It's missing some closing braces and semicolons.
  • In the toggleDarkMode function, there is a logical inconsistency where it toggles the dark mode state but sets the theme based on the previous state.
  • The React.useEffect hook is missing proper closing braces which cause syntax errors.
  • The cleanup function in the App component is missing proper closing braces.
  • The useEffect hook in App component is missing the opening brace for the callback function.
  • The UserJourneySteps function call is present but its implementation is missing.
  • The <InitState /> component is being called but its implementation is not provided.
  • There are various syntax errors and missing parts in the code which need to be fixed and completed.
  1. In the svg file unlock.svg:
  • The xmlns attribute on the <svg> tag should be an XML namespace URI.
  • The closing tags for <g> and <svg> elements are not properly aligned which can cause syntax errors.
  • The stroke attributes for each <path> tag are correct but may need adjustments based on the intended design.

Overall, there are multiple syntax errors, typos, and incomplete parts in the provided code snippets that need to be addressed and corrected. Kindly review and update accordingly.

@0xNilesh 0xNilesh merged commit b8acde8 into main Mar 21, 2024
2 of 3 checks passed
@0xNilesh 0xNilesh deleted the chat-signer branch March 21, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shift create group to new Chat screen Enable user to sign and change to write mode when user opens chat
3 participants