Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstaking new UI fix #1436

Merged
merged 4 commits into from
Apr 2, 2024
Merged

Unstaking new UI fix #1436

merged 4 commits into from
Apr 2, 2024

Conversation

abhishek-01k
Copy link
Collaborator

WORK IN PROGRESS ....

Copy link

vercel bot commented Mar 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
push-dapp ❌ Failed (Inspect) Apr 2, 2024 0:44am

Copy link

github-actions bot commented Mar 5, 2024

In the file UnstakingModalComponent.tsx:

  1. The import for Close component from 'assets/chat/group-chat/close.svg' is not used in the file. You can remove this import to clean up unnecessary dependencies.

  2. The withdrawAmount variable is misspelled, it should be withdrawAmount instead of amounttowithdraw on line 20.

  3. The txInProgressWithdraw state is defined using React.useState, it should be useState since useState is already imported on line 3.

  4. The tokenInput component is mentioned in the code but not imported nor defined in the code. It seems to be referring to the TokenInput styled component. You should confirm whether this is intended or if there is a missing import.

  5. The handleClose function is being called inside the component, but the actual function is defined after the withdrawTokens function. It's better to define functions before they are used.

  6. Inside the catch block of the promise, the template string on line 87 is incorrect. It should use backticks instead of single quotes around ${e.name}. It should be: Transaction Failed! (${e.name}).

  7. The emptyButton styled component is defined but not used in the code. You can remove it if it is unnecessary.

  8. In the MaxText styled component, there is a typo, it should be PUSH instead of PUS.

  9. In the warningText styled component, the font-family property should be 'Strawford' instead of Strawford. Also, the font-weight property should be 500 instead of 400.

Other than these points, the code structure and logic seem fine.

In the file YieldUniswapV3.tsx and NewYieldFarming.tsx, there are no obvious mistakes or typos found.

Overall, the code logic seems sound.

Your code is looking good!

Copy link

github-actions bot commented Apr 2, 2024

In the file StepsTransactionModal.tsx:

  1. Line 38: Missing closing bracket } for the retryClaimingRewards function after the else block.
  2. Line 94: There is a missing closing parenthesis ) for the call to HandleClose.

In the file StakingModalComponent.tsx:

  1. Line 58: Missing closing curly brace } for the handleInput function after the else block.
  2. Line 66: The condition in the if block if (approvedToken >= parseInt(e.target.value.replace(/\D/, '') || 0)) { is invalid. It should be properly closed with }).

Other files have not been provided in detail, so they will not be reviewed in this feedback.

Once the mentioned issues have been fixed, the code looks good.

@0xNilesh 0xNilesh merged commit a5cc19d into main Apr 2, 2024
2 of 3 checks passed
@0xNilesh 0xNilesh deleted the improved-yieldFarming-unstake-UI branch April 2, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🎨 [UI/UX Enhancement] - Unstaking Flow in Yield Farming Push Fee Pool needs to be changed
2 participants