Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

z-index issues #1430

Merged
merged 1 commit into from
Mar 6, 2024
Merged

z-index issues #1430

merged 1 commit into from
Mar 6, 2024

Conversation

pritipsingh
Copy link
Contributor

No description provided.

Copy link

File: src/App.tsx

  1. There is a missing closing curly brace '}' for the styled component 'ParentContainer'. Add '}' at the end of the styled component.
  2. In the styled component 'LeftBarContainer', remove the commented out line '// position: fixed;'. It seems unnecessary and may cause confusion.
  3. In the styled component 'ContentContainer', there is a duplicate 'margin' property. Remove the second 'margin' rule and keep the first one, which sets the left margin.

File: src/components/chat/w2wChat/searchBar/SearchBar.tsx

  1. In the first , there is a missing closing tag '' before the second . Add the closing tag ''.
  2. In the second , the closing tag '' is missing as well. Add '' after the LoaderSpinner component.
  3. In the third , the closing tag '' is also missing. Add it after the ButtonV2 component.
  4. In the Input styled component, the placeholder styling is incomplete. Add the missing styles for placeholder text.

File: src/sections/chat/ChatSidebarSection.tsx

  1. In the 'handleCreateGroup' function, there is a missing closing curly brace '}' before the render block. Add '}' after the 'return null;' statement.
  2. In the styled component 'ProfileContainer', there is a missing closing curly brace '}' at the end of the component. Add '}' to properly close the component.
  3. In the QRCodeContainer styled component, there is a missing closing curly brace '}' at the end of the component. Add '}' to properly close the component.
  4. In the TabButton styled component, the property 'pointer' should be 'cursor'. Update it to 'cursor' for proper usage.
  5. In the ProfileContainer styled component, there is a missing closing curly brace '}' after the 'border-top' property definition. Add '}' to close the component.

Overall, the code structure looks fine with the mentioned corrections.

All looks good.

Copy link
Collaborator

@mishramonalisha76 mishramonalisha76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image there are still these issues

@pritipsingh
Copy link
Contributor Author

image there are still these issues

@mishramonalisha76 Chat one is already at the lowest, I did not see chat header one, I will make the changes for it. We cannot remove the z-index of the Headed. so from the sdk side I will increase the z index of the group update modal and it should solve the things

@0xNilesh 0xNilesh merged commit abe0c55 into main Mar 6, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants