Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase 3 of Guest Mode #1423

Merged
merged 5 commits into from
Feb 22, 2024
Merged

Conversation

abhishek-01k
Copy link
Collaborator

@abhishek-01k abhishek-01k commented Feb 14, 2024

Things to review:

  • Guest Mode is working fine or not. Check all the functionality is working or not in guest mode without connecting wallet.
  • Read Only Mode is displayed or not. Logging out in read only mode.
  • Dapp does not break at any point.

Things left:

  • Connect functionality works but once connected, the app should switch to read only mode, should not prompt the user to unlock push profile
  • That option should only come once any action that requires push profile is needed, for example: opt in or replying to chat, etc
  • Chat should be compatable with Guest Mode and Read Mode

Copy link

In src/App.tsx:

  • Line 17: There is a syntax error. It looks like an opening curly brace { is missing.
  • Line 18: The opening curly brace { is not closed properly.
  • Line 19: There is a typo, it should be catch instead of casch.
  • Line 23: There is a closing bracket } missing.
  • Line 28: There is an opening curly brace { missing after the comment.
  • Line 29: There is an opening curly brace { missing after the comment.
  • Line 30: There is an opening curly brace { missing after the comment.
  • Line 31: The closing curly brace } is missing.
  • Line 40: There is an opening curly brace { missing after the comment.
  • Line 41-42: These lines are commented out, you might want to remove them altogether.
  • Line 50: There is a missing closing parenthesis ) after false.
  • Line 51: There is an opening curly brace { missing after the comment.
  • Line 52: There is an opening curly brace { missing after the comment.
  • Line 56: There is an opening curly brace { missing after the comment.
  • Line 58-59: These lines are commented out, you might want to remove them altogether.
  • Lines 62-64: There are missing closing curly braces } for the try-catch block and the if-else statement.
  • Line 66: There is an opening curly brace { missing after the comment.
  • Line 67-68: These lines are commented out, you might want to remove them altogether.
  • Line 73: There is an opening curly brace { missing after the comment.
  • Line 76: There is a missing closing parenthesis ) after themeLight.dynamicTutsBg.
  • Line 81-83: There are missing closing curly braces } for the if-else statements.
  • Line 93: There is an opening curly brace { missing after the comment.
  • Line 103: There is an opening curly brace { missing after the comment.
  • Line 112: There is an opening curly brace { missing after the comment.
  • Line 115: There is a missing closing parenthesis ) after themeLight.dynamicTutsFontColor.
  • Line 120-126: There are missing closing curly braces } for the handleJoyrideCallback function.
  • Line 128-134: There are missing closing curly braces } for the handleJoyrideCallback function and the mapDispatchToProps block.
  • Line 136: There is an opening curly brace { missing after the comment.
  • Line 137-144: These lines are commented out, you might want to remove them altogether.
  • Line 150: There is an opening curly brace { missing after the comment.
  • Line 158: There is an opening curly brace { missing after the comment.
  • Line 164-166: These lines are commented out, you might want to remove them altogether.
  • Line 170: There is an opening curly brace { missing after the comment.
  • Line 174-176: These lines are commented out, you might want to remove them altogether.
  • Line 181: There is an opening curly brace { missing after the comment.
  • Line 184-186: These lines are commented out, you might want to remove them altogether.
  • Line 191-193: These lines are commented out, you might want to remove them altogether.
  • Line 195-200: These lines are commented out, you might want to remove them altogether.
  • Line 207-211: These lines are commented out, you might want to remove them altogether.
  • Line 214-216: These lines are commented out, you might want to remove them altogether.
  • Line 223: There is an opening curly brace { missing after the comment.
  • Line 226-228: These lines are commented out, you might want to remove them altogether.
  • Line 234: There is an opening curly brace { missing after the comment.
  • Line 238-246: These lines are commented out, you might want to remove them altogether.
  • Line 276: There is an opening curly brace { missing after the comment.
  • Line 282: There is an opening curly brace { missing after the comment.
  • Line 287-289: These lines are commented out, you might want to remove them altogether.
  • Line 296: There is an opening curly brace { missing after the comment.

In src/connectors/web3Onboard.tsx:

  • Line 5-8: The imported modules are not used.

In src/contexts/AppContext.tsx:

  • Line 47: There is a missing closing parenthesis ) after appConfig.appEnv.

In src/contexts/GlobalContext.tsx:

  • The file is empty.

In src/hooks/useAccount.tsx:

  • The file is empty.

In src/primaries/Profile.tsx:

  • The file is empty.

In src/structure/Header.tsx:

  • The file is empty.

Overall, there are several syntax errors, missing curly braces, and commented out code that needs to be fixed.

@abhishek-01k abhishek-01k linked an issue Feb 14, 2024 that may be closed by this pull request
@HarshRajat
Copy link
Contributor

  • Connect functionality works but once connected, the app should switch to read only mode, should not prompt the user to unlock push profile
  • That option should only come once any action that requires push profile is needed, for example: opt in or replying to chat, etc

Copy link

In the file src/App.tsx:

  1. There is a typo in the variable name "setcurrentTime" should be changed to "setCurrentTime".
  2. In the extendConsole function, the closing brackets for the if statement are missing.
  3. In the console.enable function, there are missing closing brackets for the if statements.
  4. The condition inside the disable console.warn block is not closed properly.
  5. There are comments that are not properly closed.
  6. The handleJoyrideCallback function is missing proper closing brackets and conditions are not properly closed.
  7. The bg property in the styled component ParentContainer has a typo, it should be backgroundColor instead of bg.
  8. In the styled component LeftBarContainer, the commented out position: fixed; line can be removed as it is not used.

In the other files, no issues were found.

Please review and make the necessary corrections.

Copy link

There are multiple issues identified in the provided code snippets:

  1. In the App.tsx file:

    • Typo: setcurrentTime should be setCurrentTime.
    • Typo: CreateSpaceComponent: React.FC<ISpaceCreateWidgetProps>; should be CreateSpaceComponent: React.FC<ISpaceCreateWidgetProps>;.
    • Typo: setSidebarCollapsed should be setSidebarCollapsed in const { sidebarCollapsed, setSidebarCollapsed } = React.useContext(GlobalContext);.
    • Unmatched parentheses in if (action === 'close' || index === 20) { block.
    • spaceUI is misspelled as setcurrentTime in the spacesUIProvider component.
    • darkTheme and lightTheme are not defined.
    • Missing closing tags for some components.
    • Incorrect prop passed in ContentContainer.
    • MasterInterfacePage and SpaceWidgetSection components are not imported.
    • In the styled component LeftBarContainer, display: none; should be inside the media query.
  2. In the NavigationButton.js file:

    • Typo: ItemHV2 is used instead of ItemVV2.
    • Typo: SidebarCollapsed is used instead of sidebarCollapsed.
    • SidebarCollapsed is not defined.
  3. In the NavigationList.js file:

    • Typo: headerTag values are not properly aligned for spaces.
    • createChannel object has multiple keys with the title property and the loading property is set incorrectly.
    • Missing closing braces for some object literals.
  4. The web3Onboard.tsx, AppContext.tsx, GlobalContext.tsx, useAccount.tsx, Profile.tsx, ChatSidebarSection.tsx, Header.tsx, and MasterInterfacePage.tsx files are not provided for review.

Please address the identified issues and ensure that all necessary components, styles, and variables are correctly defined. Let me know if you need further assistance.

@0xNilesh 0xNilesh changed the base branch from main to staging-deployment February 20, 2024 13:13
Copy link

  • In the App.tsx file, the console.enable function is missing a closing curly brace } after the if (enabled) {, so it needs to be added.
  • Also, the logic to disable console logs in production environment is incomplete and inconsistent, it should be properly implemented with correct conditions and handling of different log levels.
  • There are commented-out code blocks that should be removed or uncommented if needed.
  • In the Dropdown.tsx file, there is a mistake in the Image component usage, where there is no proper closing tag for the if(dropdownValue?.icon) {...} block.
  • In the NavigationButton.js file, the handleDisallowedNav function is missing a closing curly brace } before the return statement.

All other parts in the specified files seem fine.

Please review and address the mentioned issues.

All looks good.

Copy link

In the src/App.tsx file:

  1. There are multiple typos in variable names such as 'setcurrentTime' should be 'setCurrentTime', 'SpaceInvitesComponent' should be 'SpaceInvites', 'SpaceFeedComponent' should be 'SpaceFeed', 'setSidebarCollapsed' should be 'setSidebarCollapse'.
  2. There is a missing closing brace '}' for the console.enable function.
  3. The 'extendConsole' function should be properly closed with a closing brace.
  4. The 'disable console.warn in prod' comment is not properly closed with a closing brace '}'.
  5. The 'else' block in the handleJoyrideCallback function is missing a closing brace '} else {'.
  6. In the return statement, the closing brace '}' for the App component is missing.

In the src/components/Dropdown.tsx file:

  1. In the code snippet under the 'dropdownValue?.icon && (' condition, the 'src={dropdownValue?.icon}' is not enclosed within an Image component.
  2. In the code snippet under the 'else (' condition, the 'src={dropdownValue.invertedIcon}' is not enclosed within an Image component.

In the src/components/NavigationButton.js file:

  1. The 'handleDisallowedNav' function is missing a closing brace '}'.

Other files are not reviewed as they were not provided for review.

Please make the necessary corrections in the specified files.

@0xNilesh 0xNilesh merged commit f57813e into staging-deployment Feb 22, 2024
1 check passed
0xNilesh added a commit that referenced this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

😈 [Feature Enhancement] - Phase 3 of Guest Mode Functionality
3 participants