Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sdk high level apis test #1392

Merged
merged 5 commits into from
Jan 19, 2024
Merged

Sdk high level apis test #1392

merged 5 commits into from
Jan 19, 2024

Conversation

abhishek-01k
Copy link
Collaborator

No description provided.

Copy link

File: src/App.tsx

  • There are commented-out code blocks starting from line 17. Please remove these codes if they are not needed.
  • Line 32: The code const location = useLocation(); is commented out. Please remove this line if it is not needed.
  • Lines 34-39: The code related to title and document.title is commented out. Please remove these lines if they are not needed.
  • Line 50: There is an extra closing brace (}) without a corresponding opening brace. Please remove this extra brace.
  • Lines 52-63: There is a duplicated code block related to setting the theme from localStorage. Please remove one of these blocks to avoid duplication.
  • Line 66: There is an extra closing brace (}) without a corresponding opening brace. Please remove this extra brace.
  • Line 69: There is an extra closing brace (}) without a corresponding opening brace. Please remove this extra brace.
  • Line 71: The window?.Olvy?.init() function is called without any conditional check. Please ensure that the window.Olvy object exists before calling this function.
  • Lines 79-81: There is an extra closing brace (}) without a corresponding opening brace. Please remove this extra brace.

File: src/components/ChannelDetails.js

  • Line 55: The closing brace for the addDelegate function is missing. Please add a closing brace (}) at the end of the function.
  • Line 64: The closing brace for the useEffect hook is missing. Please add a closing brace (}) at the end of the hook.
  • Line 70: There is an extra closing brace (}) without a corresponding opening brace. Please remove this extra brace.
  • Line 119: The closing brace for the removeDelegate function is missing. Please add a closing brace (}) at the end of the function.

File: src/components/InitState.tsx

  • No issues found. All looks good.

File: src/components/ViewChannelItem.js

  • No issues found. All looks good.

File: src/components/channel/NotificationSettings.tsx

  • Line 75: The redirectBack function is called without any conditional check. Please ensure that the function is only called when the condition is met.
  • Line 171: The closing brace for the addSetting function is missing. Please add a closing brace (}) at the end of the function.

File: src/components/reusables/toasts/NotifToastUI.tsx

  • Line 17: The setNotificationRecieved variable appears to have a typo. Please rename it to setNotificationReceived.
  • Line 26: The React.useEffect hook is missing its dependency array ([]). Please specify the dependencies for the hook.

File: src/components/reusables/toasts/toastController.tsx

  • No issues found. All looks good.

File: src/components/userSettings/UserSettings.tsx

  • No issues found. All looks good.

File: src/hooks/useStream.ts

  • No issues found. All looks good.

File: src/segments/Feedbox.tsx

  • No issues found. All looks good.

File: src/segments/ViewChannels.tsx

  • No issues found. All looks good.

File: src/segments/spam.tsx

  • No issues found. All looks good.

Overall, the code review looks good with some minor issues and commented-out code blocks that need to be addressed.

@0xNilesh 0xNilesh merged commit 7550e67 into main Jan 19, 2024
1 of 2 checks passed
@0xNilesh 0xNilesh deleted the sdk-high-level-apis-test branch January 19, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants