Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: connect wallet toast simplify #1343

Merged

Conversation

kalashshah
Copy link
Member

@kalashshah kalashshah commented Dec 18, 2023

fixes #1347

Copy link

  • In the file src/App.tsx:

    • Line 102: The commented-out code // hideFooter={true} should be removed.
    • Line 103: The commented-out code // primaryProps={false} should be removed.
    • Line 104: The commented-out code hideBackButton={true} should be removed.
    • Line 105: The commented-out code hideCloseButton={false} should be removed.
    • Line 106: The commented-out code disableScrolling={true} should be removed.
    • Line 107: The commented-out code disableScrollParentFix={true} should be removed.
    • Line 108: The commented-out code // disableFlip={true} should be removed.
    • Line 109: The commented-out code // showNextButton={false} should be removed.
    • Line 110: The commented-out code disableOverlayClose={true} should be removed.
  • In the file src/components/NavigationButton.js:

    • Line 52: The closing parenthesis } is missing after the condition if (disallowNavigation) {.

These are the issues found in the provided code.

Copy link

  1. In the file src/App.tsx:
  • Line 30: There is a commented out code block that starts with // else if (action === 'next' && status === 'running'). Check if it needs to be uncommented and added to the logic.
  • Line 48: Remove the unused import statement for ChannelDetails.
  • Line 60: Remove the unused import statement for ChannelSettingsDropdown.
  1. In the file src/AppLogin.tsx:
  • Line 35: Add a closing brace } after the line handleErrorMessage(authError);.
  • Line 56: Add a closing brace } after the line if (!readOnlyWallet) {.
  • Line 75: Add a closing brace } after the line const onboardModal = document.getElementById("onboard-container");.
  • Line 80: Add a closing brace } after the line if(!readOnlyWallet) {.
  • Line 98: Add a closing brace } after the line const handleReadOnlyWallet = (e: any) => {.
  • Line 117: Add a closing brace } after the line const hideOnboardModal = () => {.
  • Line 123: Add a closing brace } after the line const initiateReadOnlyMode = () => {.
  • Line 128: Add a closing brace } after the line hideOnboardModal();.
  • Line 140: Add a closing brace } after the line const initiateGuestModa = () => {.
  • Line 151: Add a closing brace } after the line hideOnboardModal();.
  • Line 160: Add a closing brace } after the line setErrorMessage(undefined);.
  • Line 165: Add a closing parenthesis ) after the line setAuthError(error);.
  1. In the file src/components/ChannelDetails.js: No issues found.

  2. In the file src/components/ChannelSettingsDropdown.tsx: No issues found.

  3. In the file src/components/NavigationButton.js:

  • Line 86: Fix the missing closing parenthesis after the line RouteLogic = Anchor;.
  • Line 93: Fix the missing closing parenthesis after the line RouteLogic = ProtectedRoute;.
  • Line 106: Add a closing brace } after the line const handleDisallowedNav = () => {.
  • Line 116: Add a closing parenthesis ) after the line ?: null.

@abhishek-01k abhishek-01k merged commit a629b13 into Read-Only-Feature-for-Dapp Dec 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants