Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt-In is now working in guest mode #1333

Merged
merged 5 commits into from
Dec 6, 2023

Conversation

abhishek-01k
Copy link
Collaborator

This PR has the guest mode and read-only feature for the dapp.

  • User has to connect the wallet once they try to opt-in in guest mode or read-only mode.
  • This PR has all the feature for the guest mode and read only mode.

Copy link

github-actions bot commented Dec 6, 2023

All looks good.

Copy link

github-actions bot commented Dec 6, 2023

In File: src/App.tsx:

  1. Line 25: Change './AppLogin' to './AppLogin.tsx' to include the file extension.

  2. Line 65: Remove the comment // const location = useLocation(); as it is not being used.

  3. Line 68: Remove the comment // Build takes care of this now as it is not needed.

  4. Line 75: Remove the comment // console.log(isActive, chainId, account); as it is not needed.

  5. Line 213: Remove the unused import statement for PushLogoDark from './assets/pushDark.svg' as it is not being used.

  6. Line 214: Remove the unused import statement for PushLogoLight from './assets/pushLight.svg' as it is not being used.

  7. Line 223: Remove the unused import statement for BlurBGClouds from 'components/reusables/blurs/BlurBGClouds' as it is not being used.

  8. Line 276: Change maxlength to maxLength in the Input component props.

  9. Line 305: Change maxllength to maxLength in the Input component props.

  10. Line 373: Remove the unused import statement for Dropdown from 'src/components/Dropdown.tsx' as it is not being used.

  11. Line 383: Remove the unused import statement for ProfileModal from 'src/components/ProfileModal.tsx' as it is not being used.

  12. Line 393: Remove the unused import statement for OptinNotifSettingDropdown from 'src/components/dropdowns/OptinNotifSettingDropdown.tsx' as it is not being used.

  13. Line 407: Remove the unused import statement for AppContext from 'src/contexts/AppContext.tsx' as it is not being used.

  14. Line 430: Remove the unused import statement for useAccount from 'src/hooks/useAccount.tsx' as it is not being used.

  15. Line 441: Remove the unused import statement for Profile from 'src/primaries/Profile.tsx' as it is not being used.

  16. Line 443: Remove the unused import statement for Header from 'src/structure/Header.tsx' as it is not being used.

  17. Line 446: Remove the unused import statement for context from 'src/types/context.ts' as it is not being used.

In File: src/AppLogin.tsx:

  1. Line 6: Change './components/reusables/blurs/BlurBGClouds' to 'components/reusables/blurs/BlurBGClouds' to correctly import the BlurBGClouds component.

  2. Line 30: Wrap the useAccount import statement in curly braces {} as it is a named import.

  3. Line 38: Remove the unused import statement for styled as it is not being used.

  4. Line 47: Change maxlength to maxLength in the Input component props.

  5. Line 61: Wrap the import for ErrorContext in curly braces {} as it is a named import.

In File: src/components/ProfileModal.tsx:

  1. Line 5: Change "styled-components" to "styled-components/native" to import the correct package.

  2. Line 8: Remove the unused import statement for Span from 'primaries/SharedStyling' as it is not being used.

  3. Line 25: Wrap the import for GlobalContext in curly braces {} as it is a named import.

  4. Line 50: Remove the unused import statement for React as it is not being used.

  5. Line 61: Remove the unused import statement for useTheme as it is not being used.

  6. Line 79: Remove the unused import statement for Image from 'primaries/SharedStyling' as it is not being used.

  7. Line 80: Remove the unused import statement for Item from 'primaries/SharedStyling' as it is not being used.

  8. Line 81: Remove the unused import statement for ItemH from 'primaries/SharedStyling' as it is not being used.

  9. Line 82: Remove the unused import statement for Span from 'primaries/SharedStyling' as it is not being used.

In File: src/contexts/GlobalContext.tsx:

  1. Line

Copy link

github-actions bot commented Dec 6, 2023

All looks good.

Copy link

github-actions bot commented Dec 6, 2023

In src/App.tsx:

  1. In line 1, there is a typo: "src/App.tsx" should be "src/App.ts".
  2. In line 3, the import statement for "InitState" should be lowercase: "import InitState from 'components/initState';"
  3. In line 5, the import statement for "AppContextProvider" should be uppercase: "import AppContextProvider, { AppContext } from 'contexts/AppContext';"
  4. In line 14, the import statement for "MasterInterfacePage" should be uppercase: "import MasterInterfacePage from 'structure/MasterInterfacePage';"
  5. In line 19, the import statement for "SectionV2" should be lowercase: "import { SectionV2 } from './components/reusables/sharedStylingV2';"
  6. In line 26, the import statement for "setIndex" should be lowercase: "import { setIndex, setRun, setWelcomeNotifsEmpty } from './redux/slices/userJourneySlice';"

In src/components/ProfileModal.tsx:

  1. In line 2, the import statement for "styled" should be lowercase: "import styled, { useTheme } from "styled-components";"
  2. In line 12, the import statement for "Image" should be lowercase: "import { A, Button, Image, Item, ItemH, Span} from 'primaries/SharedStyling';"
  3. In line 13, the import statement for "BsXLg" should be lowercase: "import { BsXLg } from 'react-icons/bs'"

Please review the remaining files and let me know if you need any further assistance.

Copy link

github-actions bot commented Dec 6, 2023

All looks good.

@kalashshah kalashshah merged commit 8e4da61 into Read-Only-Feature-for-Dapp Dec 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants