Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto_add_project.yml #1330

Merged
merged 1 commit into from
Dec 2, 2023
Merged

auto_add_project.yml #1330

merged 1 commit into from
Dec 2, 2023

Conversation

HarshRajat
Copy link
Contributor

No description provided.

@HarshRajat HarshRajat merged commit f597f47 into main Dec 2, 2023
Copy link

github-actions bot commented Dec 2, 2023

The code looks good overall. It sets up a workflow to add open issues to a project in GitHub when they are opened.

Here are a few suggestions to improve the code:

  1. It would be good to provide a more descriptive name for the workflow, instead of just "All add open issues to Push Project Tracker". This can help other developers understand the purpose of this workflow more easily.

  2. It seems that the workflow triggers on any type of issue event (opened, closed, etc.). If you only want to trigger the workflow when an issue is opened, you can remove the types section under issues. The workflow will then only trigger when a new issue is opened.

Here's the updated code:

name: Add open issues to Push Project Tracker

on:
  issues:
    opened

jobs:
  add-to-project:
    name: Auto add issues to Project
    runs-on: ubuntu-latest
    steps:
      - uses: actions/[email protected]
        with:
          project-url: https://github.com/orgs/ethereum-push-notification-service/projects/10
          github-token: ${{ secrets.ADD_TO_PROJECT_PAT }}

Other than these suggestions, the logic and configuration of the workflow look good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant