Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/multi range notif #1323

Merged
merged 9 commits into from
Dec 22, 2023
Merged

Feat/multi range notif #1323

merged 9 commits into from
Dec 22, 2023

Conversation

0xNilesh
Copy link
Member

No description provided.

@0xNilesh 0xNilesh linked an issue Nov 29, 2023 that may be closed by this pull request
Copy link

All looks good.

Copy link

All looks good.

kalashshah
kalashshah previously approved these changes Nov 30, 2023
Copy link

All looks good.

Copy link

File: src/components/SendNotifications.tsx

  • Line 40: There is a missing closing parenthesis for the if statement.
  • Line 64: There is a missing closing brace for the channelSettings logic.
  • Line 75: There is a missing closing parenthesis and brace for the useEffect hook.

File: src/components/channel/ChannelInfoList.tsx

  • Line 127: There is a missing closing brace for the props.isAddress === true condition.
  • Line 128: There is a missing closing parenthesis for the props.isAddress === true condition.
  • Line 130: There is a missing closing brace for the props.isAddress === false condition.
  • Line 131: There is a missing closing parenthesis for the props.isAddress === false condition.
  • Line 134: There is a missing closing bracket for the map function.

File: src/components/channel/NotificationSettings.tsx

  • Line 45: There is a missing closing parenthesis for the addSetting function.
  • Line 51: There is a missing closing parenthesis for the editSetting function.
  • Line 57: There is a missing closing parenthesis for the deleteSetting function.
  • Line 75: There is a missing closing parenthesis for the saveSettings function.
  • Line 85: There is a missing closing parenthesis for the catch block of the try-catch statement.
  • Line 87: There is a missing closing parenthesis for the else block of the try-catch statement.

File: src/components/dropdowns/OptinNotifSettingDropdown.tsx

  • File is missing.

File: src/components/dropdowns/UpdateNotifSettingDropdown.tsx

  • File is missing.

File: src/components/reusables/sliders/RangeSlider.tsx

  • File is missing.

File: src/helpers/channel/InputValidation.ts

  • File is missing.

File: src/helpers/channel/notifSetting.ts

  • Line 13: There is a missing closing parenthesis for the forEach function.
  • Line 16: There is a missing closing parenthesis for the push method.
  • Line 18: There is a missing closing parenthesis for the push method.
  • Line 19: There is a missing closing parenthesis for the push method.
  • Line 20: There is a missing closing parenthesis for the forEach function.
  • Line 28: There is a missing closing parenthesis for the push method.
  • Line 29: There is a missing closing parenthesis for the push method.
  • Line 32: There is a missing closing parenthesis for the push method.
  • Line 34: There is a missing closing parenthesis for the push method.

File: src/helpers/channel/types.ts

  • Line 48: There is a missing closing parenthesis and brace for the ChannelSetting type definition.
  • Line 59: There is a missing closing parenthesis and brace for the UserSetting type definition.

File: yarn.lock

  • File is missing.

All looks good.

@0xNilesh 0xNilesh merged commit b2a9028 into main Dec 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 [New Feature] - Implement multi-range notif setting
2 participants