Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YieldFarming deployed to sepolia and Issue Fixed #1315

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

abhishek-01k
Copy link
Collaborator

Issue in YieldFarming where users were unable to Unstake after claiming Rewards is Fixed.

Now, A ToolTip will be displayed stating that they have to wait for this epoch to get over before they can unstake and then the unstake button will get disable.

Copy link

File: src/components/StepsTransactionModal.tsx

  • In line 28, there is a missing closing tag for the H2V2 component.
  • In line 30, there is a missing closing tag for the H2V2 component.
  • In line 35, there is a missing closing tag for the H2V2 component.

All other parts of the code look good.

File: src/components/yield/YieldPushFeeV3.tsx

  • In line 45, there is a missing closing tag for the ItemVV2 component.
  • In line 58, there is a missing closing tag for the ItemVV2 component.
  • In line 99, there is a missing closing tag for the ItemVV2 component.
  • In line 106, there is a missing closing tag for the ItemVV2 component.
  • In line 150, there is a missing closing tag for the RewardsPaginated function.
  • In line 179, there is a missing closing tag for the unstakeTokensPaginated function.
  • In line 198, there is a missing closing tag for the useEffect hook.

All other parts of the code look good.

File: src/modules/yield/YieldFarmingModuleV2.tsx

  • In line 39, there is a missing closing tag for the useEffect hook.

All other parts of the code look good.

All looks good.

Copy link

File: src/components/StepsTransactionModal.tsx

  • Line 55: The closing tag for <H2V2> is missing.

File: src/components/yield/YieldPushFeeV3.tsx

  • Line 17: There is a missing closing parenthesis ) after setTxInProgressClaimRewards(false);.

  • Line 47: There is a missing closing parenthesis ) after }.

  • Line 55: There is a missing closing parenthesis ) after retryClaimingRewards.

  • Line 72: The closing tag for <ItemVV2> is missing.

  • Line 80: The closing tag for <ItemVV2> is missing.

  • Line 117: There is a missing opening angled bracket < before !TODO Verify Again. Edge Cases.

  • Line 135: There is a missing closing parenthesis ) after {transactionNumber}.

  • Line 157: There is a missing closing bracket } before transactionNumber.

  • Line 162: There is a missing closing bracket } before transactionNumber.

  • Line 180: The opening tag for <Spinner> is missing.

  • Line 213: The closing tag for <FilledButton> is missing.

File: src/helpers/pushStaking/src/constants.ts

  • Line 9: The value 134 for userFeesInfo should be in string format.

File: src/modules/yield/YieldFarmingModuleV2.tsx

  • Line 55: There is a missing closing parenthesis ) after handleChainChange();.

@0xNilesh 0xNilesh merged commit f4ae834 into main Nov 24, 2023
1 check passed
@0xNilesh 0xNilesh deleted the migrating-yield-Farming-test-on-sepolia branch November 24, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - Error while Unstaking in YieldFarming Push Fee Staking Pool
2 participants