Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculation fix for rewards in uni v2 #1228

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

abhishek-01k
Copy link
Collaborator

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

File: src/components/yield/YieldUniswapV3.tsx

  • Line 35: The closing parenthesis is missing after getToastIcon: (size) => <MdError size={size} color="red" />,. It should be getToastIcon: (size) => <MdError size={size} color="red" />, }).
  • Line 39: The closing parenthesis is missing after toastTitle: 'Error', toastMessage: Transaction Cancelled!, toastType: 'ERROR', getToastIcon: (size) => <MdError size={size} color="red" />, }). It should be toastTitle: 'Error', toastMessage: Transaction Cancelled!, toastType: 'ERROR', getToastIcon: (size) => <MdError size={size} color="red" />, }).
  • Line 50: The closing parenthesis is missing after setWithdrawErrorMessage("No Rewards to Claim!"). It should be setWithdrawErrorMessage("No Rewards to Claim!")}.
  • Line 51: There is a missing closing parenthesis for the if statement. It should be if (!lpPoolStats.currentEpochLP || lpPoolStats.currentEpochLP == 1) {.
  • Line 53: The closing parenthesis is missing after toastMessage: Harvest unlocks from Epoch 2!),. It should be toastMessage: Harvest unlocks from Epoch 2!),).
  • Line 58: There is a missing closing parenthesis for the if statement. It should be setTxInProgressClaimRewards(true).
  • Line 62: There is a missing closing parenthesis after getToastIcon: (size) => ( <MdCheckCircle size={size,. It should be getToastIcon: (size) => (<MdCheckCircle size={size} />,`.
  • Line 78: There is a missing closing parenthesis for the massHarvest() function call. It should be `const tx = yieldFarmingLP.massHarvest();

@MdTeach MdTeach merged commit 63ac404 into incentives-v2 Aug 7, 2023
1 check passed
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

File: src/components/yield/YieldUniswapV3.tsx

  1. Line 26: Typo in toastMessage value. Replace Harvest unlocks from Epoch 2!) with toastMessage: 'Harvest unlocks from Epoch 2!'.

  2. Line 52-54: Missing closing parenthesis } for the massClaimRewardsTokensAll function.

  3. Line 58: Missing closing parenthesis ) after <MdCheckCircle size={size} color="green" />.

  4. Line 62: Missing closing parenthesis ) after setTxInProgressClaimRewards(false).

  5. Line 74: Missing closing parenthesis ) after <MdCheckCircle size={size} color="green" />.

  6. Line 81: Missing closing parenthesis ) after setTxInProgressWithdraw(false).

File: src/config/config-dev.js

  1. Line 24: Missing comma , after "https://docs.epns.io".

  2. Line 51: Remove the comment //n after the value for uniswapV2Router02.

  3. Line 52: Remove the comment //n after the value for WETHAddress.

  4. Line 53: Remove the comment //n after the value for USDTAddress.

  5. Line 54: Remove the comment //mainnet address after the value for rockstarV2.

  6. Line 55: Remove the comment //mainnet address after the value for NFTRewardsV2.

  7. Line 61: Remove the comment //For Yield Farm V1(Deprecated).

  8. Line 75: Remove the comment //For Yield Farm V2.

  9. Line 80: Remove the comment //n after the value for yieldFarmLP.

  10. Line 81: Remove the comment //n after the value for pushCoreV2.

  11. Line 107: Missing closing parenthesis ) after pushToken: "0x2b9bE9259a4F5Ba6344c1b1c07911539642a2D33".

File: src/singletons/YieldFarmingDataStoreV2.js

There are no issues found. All looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done and Merged
Development

Successfully merging this pull request may close these issues.

2 participants