Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added New tag to YieldFarming V2 #1226

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

abhishek-01k
Copy link
Collaborator

  • Fixed the rewards claimed issue on deprecated staking.
  • Added New tag to YieldFarming V2

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

File: src/components/NavigationButton.js

  1. Line 24: "import styled, { css, useTheme } from 'styled-components';" is missing a closing parenthesis ")" at the end.

  2. Line 26: "import LoaderSpinner, { LOADER_TYPE } from 'components/reusables/loaders/LoaderSpinner';" should be changed to "import LoaderSpinner, { LOADER_TYPE } from '../reusables/loaders/LoaderSpinner';" assuming that the LoaderSpinner component is in the same directory as NavigationButton.js.

  3. Line 34: "definedMargin" variable is used without being defined earlier in the function. It should be declared before the switch statement.

  4. Line 40: Missing closing curly brace "}" for the switch statement.

  5. Line 49: "RouteLogic = Anchor;" is assigned but the closing curly brace for the else statement is missing. It should be added before the return statement.

  6. Line 52: Missing closing parenthesis ")" after the return statement.

  7. Line 59: Missing closing parenthesis ")" after the RouterLink component.

  8. Line 73: Missing closing parenthesis ")" after the ItemH component.

  9. Line 78: Missing closing parenthesis ")" after the ItemHV2 component.

  10. Line 83: Missing opening curly brace "{" before the src prop in the SelectedIcon component.

  11. Line 84: Missing closing parenthesis ")" after the SelectedIcon component.

  12. Line 102: Missing closing parenthesis ")" after the NewTag component.

  13. The code block that starts at line 111 is commented out. Please check if it should be uncommented.

  14. The code block starting at line 131 is commented out. Please check if it should be uncommented.

  15. The code starting from line 182 appears to be commented out. Please check if it should be uncommented.

  16. The css styles at the end of the file (starting from line 199) are commented out. Please check if they should be uncommented.

File: src/config/NavigationList.js

  1. Line 17: Duplicate "title" property in the headerTag object.

  2. Line 34: Duplicate "title" property in the sendNotifs object.

  3. Line 76: Duplicate "title" property in the receiveNotifs object.

  4. Lines 133-175 are commented out. Please check if they should be uncommented.

  5. Lines 182-211 are commented out. Please check if they should be uncommented.

File: src/singletons/YieldFarmingDataStore.js

  1. Line 66: The uniswapV2Router02 property is declared but not used.

  2. Line 9 of the init function: The pushToken property is not declared in the state object. It should be added.

  3. Line 10: The line "this.state.account = "0x84489FbE23fAeD458dE40Fe014377d0d56AEcdde";" is assigning a hardcoded value to the account property. It should be updated to use the "account" parameter of the init function.

  4. Line 16: The pushPriceAmounts line is missing a closing parenthesis ")" at the end.

  5. Line 87: The closing curly brace "}" for the getPoolStats function is missing.

  6. Line 88: The getTotalAvailableRewards function is missing a closing parenthesis ")" at the end.

  7. Line 92: The closing curly brace "}" for the getTotalAvailableRewards function is missing.

  8. Line 101: The closing curly brace "}" for the getAccumulatedReward function is missing.

  9. Line 103: The calculateUserEpochReward function is missing a closing parenthesis ")" at the end.

  10. Line 105: The closing curly brace "}" for the calcTotalAmountPerEpoch function is missing.

File: src/singletons/YieldFarmingDataStoreV2.js
There is no code in this file. All looks good.

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

File: src/components/NavigationButton.js

  1. There is a missing closing curly brace for the else statement on line 36. Add a closing curly brace before the "return" statement.

  2. On line 50, there is a missing closing parenthesis for the "if" condition. Add a closing parenthesis after "RouteLogic = Anchor;".

  3. On line 54, there is a missing closing curly brace for the switch statement. Add a closing curly brace after "SelectedIcon = item.isSection ? LeftBarSecondaryItemIcon : LeftBarSecondarySectionIcon;".

  4. On line 56, there is a missing default case for the switch statement. Add a "default:" case with the assignment of the SelectedIcon value.

  5. On line 65, there is a missing closing curly brace for the NavigationButton function. Add a closing curly brace before the comment "// filter: ..." on line 88.

  6. On line 97, there is a missing closing parenthesis for the "RouteLogic" component. Add a closing parenthesis after the "" component.

  7. On line 109, there is a missing closing parenthesis for the "" component. Add a closing parenthesis after the "alt={${data.alt}}`}" prop.

  8. On line 109, there is a missing opening curly brace for the else statement. Add an opening curly brace before the "src={require(../assets/${data.activeSrc})}`}" prop.

  9. On line 116, there is a missing closing parenthesis for the "" component. Add a closing parenthesis after the "" component.

  10. On line 117, there is a missing closing curly brace for the "" component. Add a closing curly brace after the "" component.

  11. On line 93, there is a commented-out code block. Remove the commented-out code block.

  12. On line 95, there is a commented-out code block. Remove the commented-out code block.

  13. On line 100, there is a commented-out code block. Remove the commented-out code block.

  14. On line 102, there is a commented-out code block. Remove the commented-out code block.

  15. On line 104, there is a commented-out code block. Remove the commented-out code block.

  16. On line 106, there is a commented-out code block. Remove the commented-out code block.

  17. On line 117, there is a commented-out code block. Remove the commented-out code block.

  18. Remove the redundant import statement for "Span" on line 5.

  19. Add an import statement for "LeftBarPrimaryItemIcon" and "LeftBarSecondarySectionIcon" components from './reusables/SharedStylingV2' on lines 7-8.

  20. Add a missing closing parenthesis for the "styled(Image)" component on line 103.

  21. Add a missing closing curly brace for the "LeftBarSecondarySectionIcon" component on line 112.

  22. Add a missing closing parenthesis for the "styled(InheritedSectionItemIcon)" component on line 113.

  23. Add a missing closing curly brace for the "LeftBarSecondaryItemIcon" component on line 120.

  24. Add a missing closing parenthesis for the "styled(SpanV2)" component on line 140.

  25. Add a missing closing curly brace for the "NewTag" component on line 144.

  26. Add a missing closing curly brace for the "NavigationButton" component on line 146.

File: src/config/NavigationList.js

  1. There is a duplicated "title" property on lines 50-51. Remove one of the duplicated "title" properties.

  2. There is a duplicated "title" property on lines 54-55. Remove one of the duplicated "title" properties.

  3. There is a duplicated "title" property on lines 115-116. Remove one of the duplicated "title" properties.

  4. There is a duplicated "title" property on lines 118-119. Remove one of the duplicated "title" properties.

File: src/singletons/YieldFarmingDataStore.js

  1. Add a missing closing parenthesis for the "resolve" callback function on line 25.

  2. Add a missing closing curly brace for the "getUserData" function on line 28.

  3. Add a missing closing parenthesis for the "Promise" constructor on line 31.

  4. Add a missing closing parenthesis for the "resolve" function on line 35.

  5. Add a missing closing parenthesis for the "resolve" function on line 41.

  6. Add a missing closing parenthesis for the "resolve" function on line 43.

  7. Add a missing closing parenthesis for the "resolve" function on line 47.

  8. Add a missing closing curly brace for the "getTotalAvailableRewards" function on line 59.

  9. Add a missing closing parenthesis for the "Promise.all" function on line 64.

  10. Add a missing closing parenthesis for the "reduce" function on line 72.

  11. Add a missing closing parenthesis for the "toFixed" function on line 73.

  12. Add a missing closing curl brace for the "getAccumulatedReward" function on line 75.

  13. Replace "for(var i=0; i<=currentEpochPUSH.toNumber(); i++)" with "for(let i=0; i<=currentEpochPUSH.toNumber(); i++)" on line 78.

  14. Add a missing closing parenthesis for the "contract.getEpochStake(this.state.account, epochId)" function on line 84.

@mishramonalisha76 mishramonalisha76 merged commit f1f7402 into incentives-v2 Aug 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done and Merged
Development

Successfully merging this pull request may close these issues.

3 participants