Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mingw tests failing, add Bcrypt lib #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

mingw tests failing, add Bcrypt lib #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions libmimalloc-sys/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ fn main() {
build.define("MI_STATIC_LIB", None);

let target_os = env::var("CARGO_CFG_TARGET_OS").expect("target_os not defined!");
let target_env = env::var("CARGO_CFG_TARGET_ENV").expect("target_env not defined!");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be unwrap_or_default(). I don't think every target defines a target-env value.


if cfg!(feature = "override") {
// Overriding malloc is only available on windows in shared mode, but we
Expand Down Expand Up @@ -61,4 +62,7 @@ fn main() {
}

build.compile("mimalloc");
if (target_os == "windows") && (target_env == "gnu") {
println!("cargo:rustc-link-lib=bcrypt");
}
}