test: Add test for vertices and edge count in pgraph #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhu960213
force-pushed
the
test/pgraph-test
branch
from
725da49
to
5c50033
Compare
purpleidea
reviewed
Nov 15, 2021
|
|
||
| // populate edges | ||
| var edges [5]Edge | ||
| for x := 0; x < len(edges); x++ { |
There was a problem hiding this comment.
You can re-use i as a counter variable here and below...
| // populate edges | ||
| var edges [5]Edge | ||
| for x := 0; x < len(edges); x++ { | ||
| var name string = "e" + strconv.Itoa(x+1) |
|
|
||
| // add edges to the vertices | ||
| for a := 0; a < len(vertices); a++ { | ||
| var b int = a + 1 |
| // add edges to the vertices | ||
| for a := 0; a < len(vertices); a++ { | ||
| var b int = a + 1 | ||
| if a <= len(vertices)-2 { |
There was a problem hiding this comment.
Subtle: -2's don't usually appear in code as much as -1's. Since we're a zero-based language, it's expected to see a -1 here and there... But you're using the -2 off of the first of the two elements... So it raises an eyebrow... So probably best to use -1 and compare it to b instead.
purpleidea
force-pushed
the
master
branch
4 times, most recently
from
2319f4f
to
04f5ba6
Compare
purpleidea
force-pushed
the
master
branch
4 times, most recently
from
fe2313c
to
271a94e
Compare
purpleidea
force-pushed
the
master
branch
3 times, most recently
from
b8072b2
to
380004b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a test for vertices and edge count in pgraph.