Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spago next #57

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Spago next #57

merged 1 commit into from
Oct 5, 2024

Conversation

jamesdbrock
Copy link
Member

@jamesdbrock jamesdbrock commented Sep 25, 2024 •
edited
Loading

Description of the change

Upgrade build system from bower to spago next.

Also upgrade deps spec, aff.

Upgrading this package’s bower dependencies has become troublesome #56 so maybe it’s time to upgrade the build system.

@f-f says https://discord.com/channels/864614189094928394/872649585816911912/1288404057404473356

“I think we're at the point where I support moving from bower.json to spago.yaml files, we're about to release a stable version for the new spago”

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@jamesdbrock jamesdbrock force-pushed the spagonext branch 6 times, most recently from 39e8101 to b15871b Compare September 25, 2024 14:32
@jamesdbrock jamesdbrock changed the title Spagonext Spago next Sep 25, 2024
@jamesdbrock jamesdbrock marked this pull request as ready for review September 25, 2024 14:35
@jamesdbrock jamesdbrock mentioned this pull request Sep 25, 2024
Closed
4 tasks
f-f
f-f reviewed Sep 25, 2024
View reviewed changes
spago.yaml Outdated Show resolved Hide resolved
@srghma
Copy link

srghma commented Oct 5, 2024

blocks deployment of https://github.com/purescript-express/purescript-express

@f-f f-f merged commit d05f697 into master Oct 5, 2024
1 check passed
@f-f f-f deleted the spagonext branch October 5, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-f f-f f-f left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesdbrock @srghma @f-f