-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename modules to allow for further extension #18
Conversation
see CHANGELOG.md for thoughts
@karlicoss curious if you had any thoughts here (I wrote up mine in the changelog) I know similar things couldn't really be done on It is a breaking change, but I'd rather break it now in one commit than later when it becomes relevant for each module in particular, if that makes sense If anyone is using my modules, its likely through my promnesia modules, so as long as they update both at the same time, there should be no issues Related issues on main repo: extensions/overrides, reddit issue |
Yep, agree, this looks good! Also new modules I'm writing are using a similar structure now. So, say we switch promnesia to use
|
yeah, this was one of my main concerns as well. Is true you can always handle it downstream, but it does start to add levels of complexity. Is something I'll consider if I get around to writing an install/update command -- perhaps it could be used for both HPI/promnesia, and if it can just leverage something known like |
less likely these are overriden, but might as well preempt them
keeping it backwards compatible + conditional warning similar to #179 follow up for purarue/HPI#18 for now without the __path__ hacking, will do it in bulk later too lazy to run test_import_warnings.sh on CI for now, but figured I'd commit it for the reference anyway
keeping it backwards compatible + conditional warning similar to #179 follow up for purarue/HPI#18 for now without the __path__ hacking, will do it in bulk later too lazy to run test_import_warnings.sh on CI for now, but figured I'd commit it for the reference anyway
keeping it backwards compatible + conditional warning similar to #179 follow up for purarue/HPI#18 for now without the __path__ hacking, will do it in bulk later too lazy to run test_import_warnings.sh on CI for now, but figured I'd commit it for the reference anyway
see CHANGELOG.md for thoughts