Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apache::params: Use correct PHP version on Ubuntu 24.04 #2575

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

flichtenheld
Copy link

Summary

Update PHP version list for Ubuntu 24.04 (noble)

Additional Context

Straightforward.

Related Issues (if any)

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@CLAassistant
Copy link

CLAassistant commented Oct 23, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://packages.ubuntu.com/noble/php confirms it's 8.3, but please fix the comment to match :)

@@ -380,6 +380,7 @@
'12' => '8.2', # Debian Bookworm
'20.04' => '7.4', # Ubuntu Foccal Fossal
'22.04' => '8.1', # Ubuntu Jammy
'24.04' => '8.3', # Ubuntu Jammy
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'24.04' => '8.3', # Ubuntu Jammy
'24.04' => '8.3', # Ubuntu Noble

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants