Update setenvif.conf to follow upstream changes #2534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings the file closer to the upstream contents as of https://git.launchpad.net/ubuntu/+source/apache2/commit/debian/config-dir/mods-available/setenvif.conf?id=696485dab93b0a8de434f051e2b85134d342dc33
mpdude
requested review from
bastelfreak,
ekohl,
smortex and
a team
as code owners
|
|
smortex
reviewed
Mar 15, 2024
There was a problem hiding this comment.
Definitively not an "upsteam" change, but the custom config of ubuntu on top of the custom config of debian for mod_setenvif seems to match the example configuration of mod_dav upsteam:
So LGTM, but there are a few more entries that seems to be incorrect and that we can sync with upsteam. I added in-line comments to them.
Co-authored-by: Romain Tartière <[email protected]>
Co-authored-by: Romain Tartière <[email protected]>
smortex
approved these changes
Mar 16, 2024
TheMeier
reviewed
Mar 19, 2024
| @@ -18,17 +18,11 @@ BrowserMatch "JDK/1\.0" force-response-1.0 | |||
| BrowserMatch "Microsoft Data Access Internet Publishing Provider" redirect-carefully | |||
| BrowserMatch "MS FrontPage" redirect-carefully | |||
| BrowserMatch "^WebDrive" redirect-carefully | |||
| BrowserMatch "^WebDAVFS/1.[0123]" redirect-carefully | |||
| BrowserMatch "^gnome-vfs/1.0" redirect-carefully | |||
| BrowserMatch "^WebDAVFS/1\.[012]" redirect-carefully | |||
There was a problem hiding this comment.
Is it on purpose that 1.3 was dropped here?
There was a problem hiding this comment.
I think so: upstream switched from 1.[01234] to 1\.[012]:
https://svn.apache.org/viewvc/httpd/httpd/trunk/docs/conf/extra/httpd-dav.conf.in?r1=1915651&r2=1915650&pathrev=1915651
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the file closer to the upstream contents as of
https://git.launchpad.net/ubuntu/+source/apache2/commit/debian/config-dir/mods-available/setenvif.conf?id=696485dab93b0a8de434f051e2b85134d342dc33
Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
puppet apply)