-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Allow to set the verbosity of the debug #2523
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm rather allergic to emojis in commit messages and would like to keep those out of the log. Can you drop it?
The tests errors does not seems to be related to my new code. |
hello ! what is missing here to see this merged in the main branch ? |
Hey! This should have been fixed in the main branch. Can you please rebase your changes on top of it? From your working directory:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor issue to check please.
acd5e6d
to
23dd8c4
Compare
@JGodin-C2C please take a look at your git history. you did a merge instead of a merge. Please do a proper rebase, as @smortex suggested, to remove the merge commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's trigger another CI!
Yep, sorry, juggling with different remote is sometime hazardous. Rebase should be correct now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That feels good!
Thanks for taking time to review my Merge Request even tho i stumbled on the carpet on repeated time |
Sorry :( i pushed to the main branch again. my bad. |
Hey @smortex i hope it's okay to query you in that way. Any way to see this approved and merged ? |
There's still a merge commit in there. |
Signed-off-by: Julien Godin <[email protected]>
Summary
Allow to set the verbosity of the debug