Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatically filter provision_service from matrix #563

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

h0tw1r3
Copy link
Contributor

@h0tw1r3 h0tw1r3 commented May 2, 2024

When testing changes with workflows on a personal fork, acceptance tests always fail because provision_service hosts are always included. This PR automatically filters them if the owner isn't puppetlabs, and the GITHUB_REPOSITORY_OWNER variable is set.

@h0tw1r3 h0tw1r3 requested a review from a team as a code owner May 2, 2024 07:49
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.95%. Comparing base (7d8dd22) to head (bba5969).

Current head bba5969 differs from pull request most recent head c0e6f93

Please upload reports for the commit c0e6f93 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #563      +/-   ##
==========================================
- Coverage   64.03%   63.95%   -0.08%     
==========================================
  Files           6        6              
  Lines         759      763       +4     
==========================================
+ Hits          486      488       +2     
- Misses        273      275       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the work :)

@david22swan david22swan merged commit 4043b2c into puppetlabs:main Jun 28, 2024
3 of 4 checks passed
@h0tw1r3 h0tw1r3 deleted the filter-matrix branch June 28, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants