use dockercli specinfra backend for docker_nodes #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes running Serverspec tests against nodes created by the docker_exp provision task. Unlike the docker bolt transport, the Serverspec docker backend uses the docker API. Unfortunately it lacks support for modern docker contexts (notably ssh).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #559 +/- ##
=======================================
Coverage 63.95% 63.95%
=======================================
Files 6 6
Lines 763 763
=======================================
Hits 488 488
Misses 275 275 ☔ View full report in Codecov by Sentry. |
david22swan
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes running Serverspec tests against nodes created by the docker_exp provision task. Unlike the docker bolt transport, the Serverspec docker backend uses the docker API. Unfortunately it lacks support for modern docker contexts (notably ssh).
Only applies to nodes created with the docker_exp provision task