(maint) - Fix failing tests exiting 0 #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the spec tests would falsely exit 0, meaning that the CI pipelines would pass and that failures would slip through the cracks. This was because we invoke rake tasks in some of our unit testing, which explicity exit with 0 (in the cause the offending tasks was litmus:check_connectivity). This exit code would interfere with the exit code 1 of the failing rspec tests, leading to a false passing CI pipeline. This now stubs the exit method, which is called during these rake tasks, and ensures that it is not actually invoked and interferes with the rspec exit code.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #558 +/- ##
==========================================
+ Coverage 63.04% 63.95% +0.91%
==========================================
Files 6 6
Lines 763 763
==========================================
+ Hits 481 488 +7
+ Misses 282 275 -7 ☔ View full report in Codecov by Sentry. |
jordanbreen28
force-pushed
the
maint-fix_0_exit_code_on_failure
branch
from
11bd80b to
bd4c6e8
Compare
david22swan
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prior to this PR, the spec tests would falsely exit 0, meaning that the CI pipelines would pass and that failures would slip through the cracks.
This was because we invoke rake tasks in some of our unit testing, which explicity exit with 0 (in this case the offending tasks was litmus:check_connectivity). This exit code would interfere with the exit code 1 of the failing rspec tests, leading to a false passing CI pipeline.
This now stubs the exit method, which is called during these rake tasks, and ensures that it is not actually invoked and interferes with the rspec exit code.
Additional Context
https://github.com/puppetlabs/puppet_litmus/actions/runs/8894625813/job/24423273766?pr=558 now failures will show.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist